Add tests.

They can be monitored on: Office hours - Automated testing

CommentFileSizeAuthor
#8 3218101-8.patch982 bytesidebr
#4 office_hours_3218101-add_test.patch3.09 KBjohnv

Comments

johnv created an issue. See original summary.

  • johnv committed 1a32f8a on 8.x-1.x 
    Issue #3218101: Add PHPUnit tests
johnv’s picture

johnv
Primary language Dutch
commented
Issue summary: View changes
johnv’s picture

johnv
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new office_hours_3218101-add_test.patch3.09 KB

Status: Needs review » Needs work

The last submitted patch, 4: office_hours_3218101-add_test.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • johnv committed 2f950da on 8.x-1.x 
    Issue #3218101: Add PHPUnit tests
  • johnv committed c387fa1 on 8.x-1.x
    Issue #3218101: Add PHPUnit tests - cardinality >1

  • johnv committed 78c031f on 8.x-1.x 
    Issue #3218101: Add PHPUnit tests - cardinality >1
idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new 3218101-8.patch982 bytes

Attached patch should fix the failing test.

  • johnv committed a4f4763 on 8.x-1.x authored by idebr 
    Issue #3218101: Add PHPUnit tests
johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs review » Active

Thanks. Committed.
Back to active for more tests.

steinmb’s picture

steinmb commented
Status: Active » Fixed
johnv’s picture

johnv
Primary language Dutch
commented

yeah, well, it is good to have no tickets lingering around, but the actual test suite is not nearly covering all functionality.
On the other hand, I see no progress, either. (except for removing (<> fixing) the always failing last test in the other ticket #3294751: Fix test failure in OfficeHoursDatetimeUnitTest)
Thanks for closing this ticket.

steinmb’s picture

steinmb commented

Perhaps just open more specific task for class/methods that needs unit tests? Easier to find and address for a random contributor.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.