Problem/Motivation

Support for using expectException() with PHPUnit\\Framework\\Error\\Warning is deprecated and will be removed in PHPUnit 10. Use expectWarning() instead.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 interdiff_11-13.txt821 bytesravi.shankar
#13 3217714-13.patch5.66 KBravi.shankar
#11 3217714-11.patch5.66 KBravi.shankar
#7 3217714-7.patch5.94 KBguilhermevp

Issue fork drupal-3217714

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !762

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review

Making the conversions.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

A nice and straightforward one.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: +PHPUnit 10
Parent issue: #3217713: Replace usages of assertFileNotIsWritable(), that is deprecated » #3217904: [meta] Support PHPUnit 10 in Drupal 11
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a re-roll.

guilhermevp’s picture

guilhermevp commented
Status: Needs work » Needs review
StatusFileSize
new 3217714-7.patch5.94 KB

re-rolled patch.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Postponed

there’s a race condition, let’s go one issue at the time

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Postponed » Needs work

Needs reroll.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3217714-11.patch5.66 KB

Added reroll of patch #7.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work 
+++ b/core/modules/user/tests/src/Kernel/Views/HandlerFilterRolesTest.php
@@ -115,8 +114,8 @@ public function testMissingRole() {
+    $this->expectWatningMessage('The test_user_role role does not exist. You should review and fix the configuration of the test_user_name view.');

Watning -> Warning

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3217714-13.patch5.66 KB
new interdiff_11-13.txt821 bytes

Addressed comment #12.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks! RTBC if bot agrees.

mondrake closed merge request !762

mondrake’s picture

mondrake
Location 🇮🇹
commented

  • catch committed e587d1e on 9.3.x 
    Issue #3217714 by mondrake, ravi.shankar, guilhermevp, longwave: Replace...

  • catch committed 36015cc on 9.2.x 
    Issue #3217714 by mondrake, ravi.shankar, guilhermevp, longwave: Replace...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

mondrake’s picture

mondrake
Location 🇮🇹
commented

One conversion missed and now tests on PHP 7.4 are broken. Filed #3218586: Missed one conversion to expectWarning().

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.