First of all: thank you for sharing this module. It saved me a lot of work.

Problem/Motivation

I had an issue with displaying the dashboard blocks. The dashboard blocks are each rendered nested, when I override the template. So the title is displaying twice.
1. in the dashboard item,
2. in the block as Block title above.

Steps to reproduce

Use the module and remove the frontend-library.

Proposed resolution

Provide a block-template for dashboard blocks, containing the required markup for the draggable libraries.
(Just apply patch for my proposed resolution)

Comments

JFeltkamp created an issue. See original summary.

jfeltkamp’s picture

StatusFileSize
new4.46 KB
jfeltkamp’s picture

StatusFileSize
new6.69 KB
jfeltkamp’s picture

Sorry, patch #3 is the correct one. The others before didn't contain the new template.

a.dmitriiev’s picture

Status: Active » Needs review

Thank you for the improvement suggestions, I think it is very good idea to make the templating more flexible. I have only one question,
does $block_instance->label() respect the configuration to display title of the block? Because now it is added without no conditional check in the patch.

  • a.dmitriiev committed 589c6e5 on 8.x-2.x authored by JFeltkamp
    Issue #3217642 by JFeltkamp: Blocks rendered nested, Block title is...
a.dmitriiev’s picture

Status: Needs review » Fixed

I confirm that "Display label" setting is still respected. I've also noticed small issues with block plugin definitions cache. So I've added clear definitions call when create/update/delete dashboard, so that the list of blocks is updated and the dashboard block is visible in the list of avalaible blocks immediately.

jfeltkamp’s picture

That's great! Thank you.
Sorry, I didn't answere to your question. The Mails from drupal.org sometimes get lost in the masses of notifications I receive every day.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.