Problem/Motivation

The following issues were reported after using https://jigsaw.w3.org/css-validator/ on a project that uses a Vartheme subtheme:

#admin-menu-search .form-control	Value Error : float auto is not a float value : auto
.form-required::after	Value Error : width Too many values or values are not recognized : calc(1.445em + 1.376rem + 4px) / 2
.form-required::after	Value Error : height Too many values or values are not recognized : calc(1.445em + 1.376rem + 4px) / 2
.form-required::after	/ is not a background-size value : calc(1.445em + 1.376rem + 4px) / 2 calc(1.445em + 1.376rem + 4px) / 2
.form-required::after	Value Error : width Too many values or values are not recognized : calc(1.445em + 1.376rem + 4px) / 2
.form-required::after	Value Error : height Too many values or values are not recognized : calc(1.445em + 1.376rem + 4px) / 2
.form-required::after	/ is not a background-size value : calc(1.445em + 1.376rem + 4px) / 2 calc(1.445em + 1.376rem + 4px) / 2

Proposed resolution

Change the factor to 6

    background-size: calc(#{$input-height} / 6) calc(#{$input-height} / 6);
    width: calc(#{$input-height} / 6);
    height: calc(#{$input-height} / 6);

User interface changes

After the Fix

API changes

  • None

Data model changes

  • None
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mhawwari created an issue. See original summary.

mhawwari’s picture

Issue summary: View changes
mhawwari’s picture

Issue summary: View changes

mhawwari’s picture

Assigned: mhawwari » Unassigned
Status: Active » Needs review
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue tags: +varbase-9.0.0
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Status: Fixed » Active
StatusFileSize
new7.34 KB

Having a regression issue on after the fix for the W3C CSS validation

They are a bit bigger.

rajab natshah’s picture

Issue summary: View changes
StatusFileSize
new6.12 KB

Change the factor to 6

    background-size: calc(#{$input-height} / 6) calc(#{$input-height} / 6);
    width: calc(#{$input-height} / 6);
    height: calc(#{$input-height} / 6);

After the Fix

rajab natshah’s picture

This fix should be reported back to Bootstrap Barrio base theme

  • RajabNatshah committed 66d9ee9 on 9.0.x
    Issue #3216704 by mhawwari, RajabNatshah: Fix W3C CSS validation issues
    
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.