Problem/Motivation

Transliterate the string that is to be added as a role on the user object

Steps to reproduce

If you do have a non-US-ASCII string e.g Reisebüro and try to add that string as a role to the user object, Mysql will throw an error.

Proposed resolution

Transliterate the string to US-ASCII characters.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3216543-2-transliterate-the-string.patch779 bytesbonrita

Comments

bonrita created an issue. See original summary.

bonrita’s picture

bonrita commented
StatusFileSize
new 3216543-2-transliterate-the-string.patch779 bytes
grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3216543-2-transliterate-the-string.patch, failed testing. View results

  • grahl committed 5427170 on 8.x-1.x authored by bonrita 
    Issue #3216543 by bonrita, grahl: Transliterate the string that is to be...
grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Needs work » Fixed

With role creation we noticed that theoretically role IDs could not be safe without not just transliteration but also other characters (though most are already excluded through the LDAP specification).

I've extended the sanitization now to grant and revoke so that we should always use a safe string for Drupal roles.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.