Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
LoggerChannelInterface misleadingly states that:
some useful data set in the $context argument of log(): request_uri, referer, ip, user, uid.
When user is not actually set.
Proposed resolution
- Remove
userfrom documentation. - Add
link,channelandtimestamp.
Remaining tasks
Patch
Review
Commit
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
TBD
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3213928-applied_patch.png | 46.59 KB | Abhijith S |
| #2 | 3213928-2.patch | 815 bytes | RoSk0 |
Comments
Comment #2
RoSk0Extended scope to list all available data.
Initial patch version.
Comment #3
RoSk0Added parent introduced the issue.
Comment #4
Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commentedApplied patch #2 and it removes the word
userand addslink,channelandtimestamp.Comment #5
quietone CreditAttribution: quietone as a volunteer commentedThe change agrees with the default logger code in terms of what the array keys of the context array are.
Therefor, setting to RTBC.
Comment #8
murilohp CreditAttribution: murilohp at CI&T commentedThe error is probably a random fail, setting to RTBC again.
Comment #9
quietone CreditAttribution: quietone as a volunteer commented@murilohp, it is better to confirm that the failing test is in fact one of the random ones, which are listed in #2829040: [meta] Known intermittent, random, and environment-specific test failures. Looking at the test results, the failing test is Drupal\Tests\Composer\Plugin\Scaffold\Functional\ComposerHookTest::testComposerHooks which is not listed on that page. Until we know for sure if that is a new random fail or not, or related to the patch (yes, I don't think it is) this should stay at Needs Work. Whatever the reason, that needs to be understood first. For that reason and to save resources (cost of running tests) setting this back to NW which will give some time to those who know that particular test to have a look.
Comment #10
murilohp CreditAttribution: murilohp at CI&T commented@quietone thanks for the response! I had no idea about the specific test failures, I'll investigate more this failed scenario.
Comment #11
murilohp CreditAttribution: murilohp at CI&T commentedWe already have an issue to solve the test error! #3255863. I think we can wait for this, reroll the patch and then move back to RTBC.
Comment #12
murilohp CreditAttribution: murilohp at CI&T commentedNow the #3255863 is merged, I retested the patch #2, and it's passing, moving back to RTBC.
Comment #13
alexpottCommitted and pushed 1e65e36e7e6 to 10.0.x and 1d64f860f3b to 9.4.x and 39a075f30aa to 9.3.x. Thanks!
Backported to 9.3.x since this is only documentation.