Problem/Motivation

There is no way to save configuration on `Paragraphs library item settings` form.
Path: /admin/config/content/paragraphs_library_item

Steps to reproduce

- Enable any module that adds some configuration to this form (for example, Rabbit Hole).
- There is no `Save configuration` button on the form.

Proposed resolution

LibraryItemSettingsForm::buildForm should call parent method ConfigFormBase::buildForm.

User interface changes

Before (no settings):
before - 1

Before (3rd-party settings available):
before - 2

After:
after

CommentFileSizeAuthor
#7 after patch - Save button.png135.99 KBdeepalij
#7 before patch - with module.png131.62 KBdeepalij
#7 before patch - no save button.png95.28 KBdeepalij
#4 Screenshot 2021-05-20 at 22.20.01.png73.36 KBmatroskeen
#4 Screenshot 2021-05-20 at 22.19.05.png60.43 KBmatroskeen
#4 Screenshot 2021-05-20 at 22.18.03.png48.7 KBmatroskeen

Issue fork paragraphs-3213800

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bohart created an issue. See original summary.

bohart opened merge request !8

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Needs work » Needs review

Tested locally on: Drupal 9.1.7 + Paragraphs 8.x-1.12.

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2021-05-20 at 22.18.03.png48.7 KB
new Screenshot 2021-05-20 at 22.19.05.png60.43 KB
new Screenshot 2021-05-20 at 22.20.01.png73.36 KB

#3213798: Paragraphs Library support is landed, so now this form has a configuration if the Rabbit Hole submodule is enabled.

It might look confusing because we have "There are no settings yet." sentence and at the same time the "Rabbit Hole settings" fieldset is available.
I consider it as a minor point that shouldn't block this issue, therefore moving it to RTBC.

I'm adding screenshots to the issue summary to make it easier for maintainers to review.

taniachque made their first commit to this issue’s fork.

taniachque’s picture

taniachque commented
Status: Reviewed & tested by the community » Needs review
deepalij’s picture

deepalij commented
StatusFileSize
new before patch - no save button.png95.28 KB
new before patch - with module.png131.62 KB
new after patch - Save button.png135.99 KB

Applied patch (MR) #5 on Drupal version 10.1.x-dev
Patch applied cleanly.
Able to reproduce the issue.
The "Save configuration" button is visible now after applying the patch. Patch fixed the issue

Before patch
before

Before patch - with module
before

After patch
after

Can be moved to RTBC
RTBC+1

parisek’s picture

parisek
Primary language Czech
commented
Status: Needs review » Reviewed & tested by the community

Working great thank you, moving to RTBC

Berdir made their first commit to this issue’s fork.

  • Berdir committed 87146ba3 on 8.x-1.x authored by bohart 
    Issue #3213800: Save button is missed on`Paragraphs library item...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Not sure what settings rabbit hole adds here exactly and it's a bit weird to have a button when there are no settings, but fine I suppose.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.