Problem/Motivation

A JSON:API Menu Items query that applies filters will result in a 403 status code if no results are found.

Steps to reproduce

/jsonapi/menu_items/main?filter[parent]=fake

Proposed resolution

Don't result in a 403, it's not access denied, it's a valid, empty result.

Remaining tasks

Make the change.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork jsonapi_menu_items-3213317

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Deciphered created an issue. See original summary.

Deciphered opened merge request !5

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review
shadcn’s picture

shadcn commented
Status: Needs review » Reviewed & tested by the community

We came across this issue today.

This patch fixes it. Agreed on the 200 response.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Reviewed & tested by the community » Fixed

Done, thanks for the review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

Was the MR really merged? The MR is still open and I don't see commit for this in the commit log.

larowlan made their first commit to this issue’s fork.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Closed (fixed) » Reviewed & tested by the community

Looks like it was missed, I've rebased it and will commit if it passes

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

This is showing as 301ddc3 in the HEAD of 1.2.x

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

Thank you @larowlan! Are you planning to make a new tagged release that would include this? This would be a great DX improvement to ship 🙏

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Sure, can do - 1.2.3 is packaging now

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.