Olivero: Z-index issue with the search bar.

Adding screen recording for reference.

Steps to reproduce:

1. go to /search/node
2. open the search bar
3. scroll down and scroll up.
4. you will see search bar has a low z-index to Contnent/User tabs.

CommentFileSizeAuthor
#14 search_zindex_after.mp4780.15 KBkiran.kadam911
#14 search_zindex_before.mp4743.65 KBkiran.kadam911
#14 Screenshot 2021-08-19 at 2.40.32 PM.png394.03 KBkiran.kadam911
#13 After Patch 3212670.mp41.22 MBchetanbharambe
#13 Before Patch 3212670.mp41.45 MBchetanbharambe
#8 3212670-8.patch926 bytesshashwat-tiwari
#4 after-patch.mp4744.8 KBrinku jacob 13
#4 before-patch.mp4654.07 KBrinku jacob 13
#2 3212670.2.patch846 bytessakthivel m
Screen Recording 2021-05-07 at 08.07.49.mov3.3 MBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

sakthivel m’s picture

sakthivel m commented
Status: Active » Needs review
StatusFileSize
new 3212670.2.patch846 bytes

#2 Please review the patch

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Reviewed & tested by the community

Patch #2, fixes the issue. Attaching a screen recording for reference.

Sakthivel M, thank you for working on this.

Moving to RTBC.

rinku jacob 13’s picture

rinku jacob 13 commented
StatusFileSize
new before-patch.mp4654.07 KB
new after-patch.mp4744.8 KB

patch #2 successfully applied for 9.3.x-dev

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3212670.2.patch, failed testing. View results

sakthivel m’s picture

sakthivel m commented
Status: Needs work » Reviewed & tested by the community
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Reviewed & tested by the community » Needs work

The fix looks good, but lets add a comment to indicate why we're setting a z-index. Something like // Appear in front of Drupal's tabs.

shashwat-tiwari’s picture

shashwat-tiwari commented
Status: Needs work » Needs review
StatusFileSize
new 3212670-8.patch926 bytes

Added the comment for z-index.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

Looks good!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 3212670-8.patch, failed testing. View results

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs work » Reviewed & tested by the community

This is an unrelated test failure.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs review

Does this problem still exist? I'm having difficulty reproducing this.

chetanbharambe’s picture

chetanbharambe commented
Status: Needs review » Needs work
StatusFileSize
new Before Patch 3212670.mp41.45 MB
new After Patch 3212670.mp41.22 MB

Verified and tested patch #8.
Patch applied successfully but not working as expected.

Testing Steps:
# Go to Appearance: Set Olivero theme
# Open the search bar
# Scroll down and scroll up.
# You will see search bar has a low z-index to Content/User tabs.

Expected Results:
# User should see the search bar remain as it is when doing scroll down.

Actual Results:
# Currently search bar is not appearing when the user is doing scroll down.

Please see attached videos
Not working as expected.
Can be a move to Needs work.

kiran.kadam911’s picture

kiran.kadam911
he/him
Location Mumbai, India 🇮🇳
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new Screenshot 2021-08-19 at 2.40.32 PM.png394.03 KB
new search_zindex_before.mp4743.65 KB
new search_zindex_after.mp4780.15 KB

Patch #8 applied successfully.

Working as expected. The z-index issue(overlapping) of the search bar on scroll while animating from left to right is resolved with a patch.

Before patch SS and screencase is attached:

After patch screencast is attached.

Can be a move to RTBC.

Thanks!

  • lauriii committed aafc501 on 9.3.x 
    Issue #3212670 by Sakthivel M, shashwat-tiwari, kiran.kadam911,...

  • lauriii committed 0d4cdf5 on 9.2.x 
    Issue #3212670 by Sakthivel M, shashwat-tiwari, kiran.kadam911,...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed aafc501 and pushed to 9.3.x. Also cherry-picked to 9.2.x because Olivero is experimental. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.