Problem/Motivation

VBO is not processing all selected language versions of the same entity when processing is done in a batch.

bug screenshot

Steps to reproduce

  1. Install Drupal using the standard install profile
  2. Download vbo composer require drupal/views_bulk_operations
  3. Log in as admin
  4. Enable vbo from the extend menu
  5. Enable content translation from the extend menu
  6. Add two new languages Finnish and German
  7. Enable translation for basic page content type
  8. Create 2 basic page nodes
  9. Translate one of the created nodes to both languages
  10. Create a new view that list all basic pages, display format table and items to display 2 per page
  11. Add bulk operation "Save content item" to that view, set Process in a batch operation enabled and batch size to 2
  12. Check all 2 rows from table and "Select / deselect all results in this view (all pages, 4 total)"
  13. Select "Save content item" action and click "Apply to selected items" button
  14. Result is "Action processing results: Save content item (3)."
  15. Modify the view and uncheck "Process in a batch operation" from the VBO field
  16. Repeat steps 12 and 13
  17. Now the result is Action processing results: Save content item (4).

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 vbo_act_on_translations-3210957-8.patch2.02 KBliquidcms
4.png39.16 KBmikran

Issue fork views_bulk_operations-3210957

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mikran created an issue. See original summary.

andrimont’s picture

andrimont commented

I can see the same issue : the translated content cannot be modified during a VBO batch process.

alvar0hurtad0 made their first commit to this issue’s fork.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Assigned: Unassigned » alvar0hurtad0

Working on this.

alvar0hurtad0 opened merge request !12

papagrande’s picture

papagrande
Primary language English
commented
Status: Active » Reviewed & tested by the community

I can confirm that the MR fixes the problem on a client's site.

The code looks fine to me, but I claim no expertise with the ViewsBulkOperationsActionProcessor service nor do I know why the tests aren't passing.

graber’s picture

graber commented
Status: Reviewed & tested by the community » Needs work

Sorry but tests must pass for this to be RTBC.

liquidcms’s picture

liquidcms commented
StatusFileSize
new vbo_act_on_translations-3210957-8.patch2.02 KB

patch file for MR listed above.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Assigned: alvar0hurtad0 » Unassigned

  • Graber committed 9242b77 on 4.1.x 
    Issue #3210957 by alvar0hurtad0, liquidcms, mikran: VBO is skipping...
graber’s picture

graber commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.