The tests in #2081585: [META] Modernize the History module look like they are targeting MR !16 instead of !17.

DrupalorgIssueFork::getMergeRequestIID() looks up the merge request by source branch. In this case, both merge requests have the same source branch. We should also be checking the target branch, which is different between the two merge requests.

We don’t have the target branch in the DB right now, so we need to add a column to drupalorg_issue_fork_branches and back-fill that data.

Issue fork drupalorg-3208796

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

drumm created an issue. See original summary.

drumm credited andypost.

drumm’s picture

Issue summary: View changes

andypost reported this via Slack.

  • drumm committed aa524d6 on 7.x-3.x
    Issue #3208796: Add {drupalorg_issue_fork_branches}....

  • drumm committed 2ea8262 on 7.x-3.x
    Issue #3208796: Keep track of target branch as merge requests are...

  • drumm committed 2c26754 on 7.x-3.x
    Issue #3208796: Back-fill {drupalorg_issue_fork_branches}....

  • drumm committed be75d0e on 7.x-3.x
    Issue #3208796: Use target branch in merge request lookup
    
drumm’s picture

Status: Active » Fixed

This is now resolved.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.