Problem/Motivation

The response from Bitbucket Pipelines is not correctly validated and so deployments are never marked as complete. This causes the changelog to endlessly grow.

Steps to reproduce

1. Enable a Bitbucket Pipelines front end environment.
2. Make content changes and note that the changelog count increases.
3. Perform a deployment.

Expected Result:
Changelog clears and deployment is marked as triggered.

Actual Result:
Changelog doesn't change and a warning is displayed.

Proposed resolution

Respond correctly to the 201 CREATED response from Bitbucket.

Issue fork build_hooks-3206509

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andycarlberg created an issue. See original summary.

andycarlberg opened merge request !3

andycarlberg’s picture

andycarlberg
he/him
commented

My merge request includes another minor bug fix for deployments that are "In Progress" and didn't have a result to display. If that needs to just be separated to it's own issue, let me know. It seemed minor enough to just include.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

We should be able to write a kernel test for this.

See \Drupal\Tests\build_hooks\Kernel\BuildHooksKernelTestBase::assertFrontendEnvironmentBuildHook for an example of how that would look, you could mimic both the success and the fail.

andycarlberg’s picture

andycarlberg
he/him
commented

Added the Kernel test. The test also uncovered incorrect names in the schema file so I updated those accordingly.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Fixed

Nice catch, kernel tests++

this will go out as 3.0.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.