Create autocomplete JS library

retitled to make it look better on in the core js queue

@bnjmnm I like Nightwatch, but if you think there's a more appropriate tool then I think that's fine too. Once didn't use Nightwatch because it's not testing any UI interactions.

Could we get rid of the class syntax so this isn't an issue? Anecdotally they seem to be increasingly unpopular since they're only syntactic sugar and not really OOP anyway. For the polyfills let's have Drupal take care of that, we'll probably end up with polyfills embedded multiple times otherwise.

Just a heads up you might want to take a look at https://www.drupal.org/project/once/issues/3201195 since I had to remove "type: module" from package.json as it doesn't play very nicely with other packages (like Nightwatch)

Re #4: I don't think we should ship polyfills as part of the build in this package - it should be the responsibility of the projects to add dependency on required polyfills. We could document in the project which polyfills are required for IE 11 support.

@bnjmnm can we use .apply instead?

Thanks!

1. There are test files at the root (db.json, server.js, jsonServer.js), I'd rather have them in a subdirectory so it's easier to group and exclude from the package.
2. I know it's a bit annoying but README.old.md doesn't look good for an initial commit. I'd rather remove the jsdoc2md command from package.json and keep the furnished readme as README.md and open an issue to fix README generation.
3. A bit of mix and match with npm, yarn, etc. we should either use yarn or not in package.json scripts (looking at the test:nightwatch command)
4. eslint/prettier, we should have the prettier plugin for eslint so no need for a dedicated command no?
5. The indent of .eslintrc.json is all over the place, not a huge deal but it's an easy fix :)
6. To discuss but I'd rename everything autocomplete not a11y.autocomplete to avoid issues with L and 1 (including package name, so @drupal/autocomplete, we keep the namespace on drupal.org for now, might end up in the monorepo down the line)
7. The license bit is deprecated, see #3211084: fix license information on npmjs.com for how to change it

In any case, good start :)

Pre commit:

1. For me only thing left is to have a functional yarn build

   seems like a yarn build has some funky results, the generated file in dist is not usable in a browser :

   "use strict";
   
   require("core-js/modules/es.symbol.js");
   
   // … 
   

   the rest of the commands are working as expected.

Post commit:

• I still think the name should be changed to drop the a11y part but that can be done until we release the first version.
• for the testing I'm wondering if there isn't a simper way than spawning a bunch of servers to serve a static html+json file. It's not a blocker but would be good to improve before v1.0.0

@justafish: what do you think?

That looks better :)

Good enough MVP for me, could use a +1 from justafish if she has some time.

let's keep the readme to the other issue. The template is not necessary if the default output is good, let's talk about that in the related issue :)

Just giving some time to sally to have a look.

I've pushed some updates -

• Moves to Yarn 2
• Replaces chromedriver with geckodriver (as it wasn't working for me)
• Adds the prettier and eslint configurations from once.js
• Adds a GitLab CI file for running tests and releases
• Adds export metadata to package.json
• Abstracts the class implementation with a factory function so we can change it later if we want without breaking the API
• Updated dependencies

The test doesn't seem to be passing - I added the GitLab CI file first so you can see it failing before I added the factory https://git.drupalcode.org/project/a11y_autocomplete/-/jobs/7385

@nod_ and I are going to merge this and then open follow up issues individually for pre-release items

All good :) Sally will open a couple of follow-ups