The fid has been used as the localStorage key when storing puzzle progress. This is sloppy and could result in name collisions too easily. All crossword storage should be under the crossword localStorage key.

CommentFileSizeAuthor
#3 crossword--local-storage--3203883--3.patch3.59 KBdanflanagan8
#2 crossword--local-storage--3203883--2.patch3.86 KBdanflanagan8

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
StatusFileSize
new crossword--local-storage--3203883--2.patch3.86 KB
danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
StatusFileSize
new crossword--local-storage--3203883--3.patch3.59 KB

It took me about 5 seconds to hate that patch. The data is read and written frequently, so let's give each puzzle its own entry, with a key like crossword:123 where the number is the fid.

  • danflanagan8 committed 948d0fa on 8.x-1.x 
    Issue #3203883 by danflanagan8: Change local storage structure to avoid...
danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.