Missing config schema for exclude_disabled_menu_items

Thanks for identifying.

Even though this only really causes problem in a test environment, would you be willing to make a new release for this?

We had to commit the patch to our project and apply it with Composer so that our CI tests for our custom profile could keep running with this module as a dependency.

Thanks for considering. Regardless, this module is great and does exactly what we needed! 🙏 Your work is very much appreciated :)

Seems fair - I've opened #3212243: Release coordination issue for Menu Breadcrumb 8.x-1.15 to co-ordinate, and we can identify other recently merged issues there.

(Hi @rphair, lmk if this sort of helping is not helping?!)

hi @xurizaemon & thanks for asking - this was delayed to check into mainstream because, around the end of a general 2 week waiting period for pushing dev commits into a newly numbered release, there came another issue (#3208118: Hide the breadcrumb if it only contains the link to the front page) which suggested there might be changes to the options wording and/or the Help screen.

It took a while to understand the earlier request & then rule it out... until that time it would have made sense to include those relatively trivial changes in a bump release along with these. Sorry about the unusual delay @gabesullice & it's just been merged into 1.15 now.

This was an undemocratic ruling so I as usual I would give the OP time to post a rebuttal, give further information, or for third parties to express second opinions about the issue. While in that further day-or-so waiting period @gabesullice 's comment was submitted.

Generally a single comment like that would be enough to schedule an immediate merge, and will be enough in the future unless something unusual happens. Nobody should be shy about pressing for a release when they need it, but nobody should need to submit "tracking" issues either. The mixing together of a bunch of concurrent issues this time (e.g. #3212243: Release coordination issue for Menu Breadcrumb 8.x-1.15) has just led to a minor explosion of work that otherwise would have been routine.

Wow! Thanks for the quick response and release. That happened faster than I expected :D

@rphair++

Whoops! @rphair, I think you accidentally tagged the wrong commit:

$ git log --pretty=oneline --abbrev-commit
a7a7b4c (HEAD -> 8.x-1.x, origin/8.x-1.x) Issue #3203179 by JeroenT, rphair: Missing config schema for exclude_disabled_menu_items
8e11771 (tag: 8.x-1.15, tag: 8.x-1.14) Issue #3165239 by NicolasGraph, rphair: Programmatically building breadcrumbs for non current pages fails to resolve the page title
0e2daed (tag: 8.x-1.13) Issue #3137496 by cgoffin, rphair, p-neyens: Hide disabled menu items from the breadcrumb
...

Shouldn't the 8.x-1.15 tag been on a7a7b4c?

(edit: corrected ordinary git mistake; see final comment)

(edit: corrected ordinary git mistake; see final comment)

(edit: corrected ordinary git mistake; see final comment)

@gabesullice I know what happened now. I approved the changes directly in the repo so in fact I never would have created a local 3203179-missing-config-schema branch at all. Then by habit I added the tag in my local version which applied it to the most recent commit in my current 8.x-1.x branch, which was the one for version 1.14. So that commit ended up with 2 tags.

OK it's been pushed out again as version 1.16 which shows the code from the commit above in the repository here: https://git.drupalcode.org/project/menu_breadcrumb/-/blob/8.x-1.16/confi...

And I believe the top of the git log now makes sense:

$ git log --pretty=oneline --abbrev-commit
f785383 (HEAD, tag: 8.x-1.16, 3203179-missing-config-schema) Issue #3203179 by JeroenT, rphair: REAPPLIED RELATIVE TO 1.14 (1.15 merge error) Missing config schema for exclude_disabled_menu_items
...

Thanks! That was indeed the fix we needed. Very much appreciated!