Problem/Motivation

Using the latest -dev the Source list limit settings does not work. It is set to 20 by default, but it is showing less than 20 items per page.

Issue fork tmgmt-3202731

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eyilmaz created an issue. See original summary.

eyilmaz’s picture

eyilmaz
Primary language German
Location Berlin, Germany
commented

Looks like a
$query->distinct(TRUE); is missing in ContentEntitySourcePluginUi::buildTranslatableEntitiesQuery

eyilmaz opened merge request !1

eyilmaz’s picture

eyilmaz
Primary language German
Location Berlin, Germany
commented
Status: Active » Needs review

committed the change and opened Merge request.

johnzzon’s picture

johnzzon
Primary language Swedish
Location Gothenburg 🇸🇪
commented
Status: Needs review » Reviewed & tested by the community

Had this same issue. Espcecially after applying a filter, I got 1 row in the table but 13 pages.

The MR solved it for me.

Berdir made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Closed #3213377: Content Overview (Content Entity) shows multiple time the same content on different pagination pages. as a duplicate.

Took me a moment to understand this, first thought it's related to translations but then we'd have noticed this earlier. Turns out the problem is with revisions and the somewhat recent change to join the revision data table.

Added test coverage and pushed that to the merge request.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Merged.

  • Berdir committed 7d96623 on 8.x-1.x authored by eyilmaz 
    Issue #3202731 by eyilmaz, Berdir: Source list limit does not work

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sachintyagi99’s picture

sachintyagi99 commented

Hi,

I can't see this line($query->distinct();) in latest module "tmgmt 8.x-1.12". Please check.
The below commit(#3202731) is not pushed in the latest version module:
https://git.drupalcode.org/project/tmgmt/-/merge_requests/1/diffs?commit...

Thanks.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

That's now how versions work. This will be part of the next release, existing release are never updated. You can use the patch or the dev version in the meantime.

sachintyagi99’s picture

sachintyagi99 commented

@Berdir thanks for the update.

thibmrt’s picture

thibmrt commented

@Berdir many thanks !