Site Studio - Lingotek only pulling in last field in a series of repeater fields

Crediting @marcaddeo for a wonderful report and a starting patch for extracting the data.

Attached patch that should fix the issue.

Thanks @marcaddeo!

Added a test on top of your patch.
No interdiff, the tests-only patch serves as such.

Committed c8c3a14 and pushed to 3.5.x.
Cherry-picked a2f9225 and pushed to 3.6.x.

Attributed to @marcaddeo as he did most of the work here. Thanks!

This is awesome, Marc. Thanks!
Setting as needs review to trigger the testbot

Rerolled the patch on top of the one already committed.
This patch will go only on 3.6.x, so testing against that.

1. +++ b/src/LingotekContentTranslationService.php
   @@ -824,65 +828,149 @@ class LingotekContentTranslationService implements LingotekContentTranslationSer
   -  private function processCohesionComponentsValues($values, $component_model, $nested_key = []) {
   -    $data_layout = [];
   +  protected function extractCohesionComponentValues(array $component_model, $values) {
   +    $field_values = [];
   

   As I made this private, the API change can be accepted. I'm good having it as protected.

2. +++ b/src/LingotekContentTranslationService.php
   @@ -824,65 +828,149 @@ class LingotekContentTranslationService implements LingotekContentTranslationSer
   +  protected function extractCohesionComponentValues(array $component_model, $values) {
   

   This full piece of code is far more readable, thanks!

3. +++ b/src/LingotekContentTranslationService.php
   @@ -824,65 +828,149 @@ class LingotekContentTranslationService implements LingotekContentTranslationSer
   +      $blacklist = [
   +        'cohTypeahead',
   +        'cohEntityBrowser',
   +        'cohFileBrowser',
   +      ];
   +      $component_type = $settings->type ?? NULL;
   +      // Skip blacklisted component types.
   +      if (in_array($component_type, $blacklist)) {
   +        continue;
   +      }
   

   I'm against the use of the term blacklist, let's use a more friendly term as $skippedComponentTypes. The comment then will be superfluous.

Added fix for the tests to pass after changing the escaping.
I'm not 100% sure this is desirable for every component type tho.

If it works for you I guess we are fine.

If you mean *on upload from Drupal to Lingotek*, there are hooks in the Drupal side, and on TMS import the content run through a set of configurable filters, but being fair I think it's better to send it this way, unless you have a use-case I'm missing.
If you mean *on download from Lingotek to Drupal*, there are hooks in the Drupal side.

Should we commit and release this for you?

Committed 8260eea and pushed to 3.5.x.
Cherry-picked f144c16 and pushed to 3.6.x. Thanks!

Created #3208606: Avoid the spread operator on array as it is not supported in php 7.3