Problem/Motivation

\Drupal\linkychecker\LinkyCheckerCrawlQueue::getLinksNeedingUpdate does not sort links, so those most in the need of checking don't necessarily get queued first.

Proposed resolution

Add a sort

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 3199599-5.patch619 bytesPooja Ganjage
#3 3199599-2.patch621 bytesPooja Ganjage

Issue fork linkychecker-3199599

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

larowlan opened merge request !1

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3199599-2.patch621 bytes

Hi,

Creating a patch for this issue.

Please review the patch.

Let me know if any suggestions.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3199599-5.patch619 bytes

Updated Patch.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Thank you for the patch @Pooja Ganjage but there is already a merge request for the issue. It has a sorting condition and a test as well. Please have a look and review https://git.drupalcode.org/project/linkychecker/-/merge_requests/1. Feel free to leave a comment if you have any questions or suggestions.

acbramley’s picture

acbramley commented
Status: Needs review » Reviewed & tested by the community

MR looks good to me!

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Reviewed & tested by the community » Needs work

Tiny nit, as to not open a portal to the dark web.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Oh, I just thought I was being clever spelling example backwards, didn't realise it was an actual site!

Fixed

dpi’s picture

dpi
Location Perth, Australia
commented

  • dpi committed 3dd24e1 on 8.x-1.x authored by larowlan 
    Issue #3199599 by larowlan: Sort links in \Drupal\linkychecker\...

  • dpi committed f53dfb9 on 2.x authored by jibran 
    Issue #3199599 by jibran: Fixed test groups
dpi’s picture

dpi
Location Perth, Australia
commented
Version: 8.x-1.x-dev » 2.x-dev
Status: Needs work » Fixed

Thanks Jibs

Fixed and pushed to the new 2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.