Improve Paragraphs Usage module

Thank you for this patch,

In these tests (testCheckIfUsed and testCheckIfNotUsed), phpunit create paragraphs with term but if node module is enable and that node module doesn't have bundle, we have theses notices.

Exception: Notice: Undefined index: bundle
Drupal\paragraphs_usage\Service\ParagraphsUsageService->setUsedParagraphs()() (Line: 95)

in you patch I have coding standard errors too, can you fix these errors

FILE: project/web/modules/custom/paragraphs_usage/src/Controller/ParagraphsUsageController.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
  9 | WARNING | [x] Unused use statement
 28 | ERROR   | [ ] Missing short description in doc comment
 33 | ERROR   | [ ] Parameter $paragraphs_usage_service is not described in comment
 77 | WARNING | [ ] Line exceeds 80 characters; contains 215 characters
 77 | ERROR   | [x] Comments may not appear after statements
 77 | ERROR   | [x] No space found before comment text; expected "// Url::fromRoute('entity.' . $entity_type_used . '.edit_form', [$entity_type_used =>
    |         |     $used_paragraph['bundle']]);" but found "//Url::fromRoute('entity.' . $entity_type_used . '.edit_form', [$entity_type_used =>
    |         |     $used_paragraph['bundle']]);"
 77 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 83 | WARNING | [x] A comma should follow the last multiline array item. Found: ')'
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: project/web/modules/custom/paragraphs_usage/src/Service/ParagraphsUsageService.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 40 ERRORS AND 5 WARNINGS AFFECTING 35 LINES
-------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [ ] Missing required strict_types declaration
  12 | ERROR   | [x] Doc comment short description must end with a full stop
  14 | ERROR   | [x] Doc comment long description must end with a full stop
  20 | ERROR   | [ ] Missing short description in doc comment
  25 | ERROR   | [ ] Missing short description in doc comment
  30 | ERROR   | [ ] Missing short description in doc comment
  35 | ERROR   | [ ] Missing short description in doc comment
  36 | ERROR   | [x] Data types in @var tags need to be fully namespaced
  40 | ERROR   | [ ] Missing short description in doc comment
  47 | ERROR   | [ ] Missing short description in doc comment
  57 | ERROR   | [ ] Missing parameter comment
  58 | ERROR   | [ ] Missing parameter comment
  59 | ERROR   | [ ] Missing parameter comment
  70 | ERROR   | [x] Doc comment short description must start with a capital letter
  70 | ERROR   | [x] Doc comment short description must end with a full stop
  72 | ERROR   | [x] Doc comment long description must start with a capital letter
  72 | ERROR   | [x] Doc comment long description must end with a full stop
  74 | ERROR   | [ ] Missing parameter comment
  82 | ERROR   | [x] Doc comment short description must start with a capital letter
  82 | ERROR   | [x] Doc comment short description must end with a full stop
  84 | ERROR   | [ ] Description for the @return value is missing
  91 | ERROR   | [x] Doc comment short description must start with a capital letter
  91 | ERROR   | [x] Doc comment short description must end with a full stop
 133 | ERROR   | [x] Doc comment short description must start with a capital letter
 133 | ERROR   | [x] Doc comment short description must end with a full stop
 135 | ERROR   | [ ] Missing parameter comment
 135 | ERROR   | [ ] Missing parameter type
 136 | ERROR   | [ ] Missing parameter comment
 136 | ERROR   | [ ] Missing parameter type
 137 | ERROR   | [ ] Missing parameter comment
 138 | ERROR   | [ ] Missing parameter comment
 143 | ERROR   | [ ] Type hint "null" missing for $bundle_entity_type
 143 | ERROR   | [x] Expected 1 space between type hint and argument "$field_definition"; 2 found
 145 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 149 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 159 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 160 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 165 | ERROR   | [x] Doc comment short description must start with a capital letter
 166 | ERROR   | [ ] Doc comment short description must end with a full stop
 166 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 170 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 172 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 179 | ERROR   | [x] Doc comment short description must start with a capital letter
 180 | ERROR   | [ ] Doc comment short description must end with a full stop
 180 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

thanks

I have PHPCS errors again with your patch:

FILE: project/web/modules/custom/paragraphs_usage/src/Service/ParagraphsUsageService.php
----------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
----------------------------------------------------------------------------------------
  56 | ERROR | [x] Additional blank lines found at end of doc comment
  64 | ERROR | [x] Additional blank lines found at end of doc comment
  90 | ERROR | [ ] Missing parameter comment
 155 | ERROR | [ ] Parameter comment must start with a capital letter
 157 | ERROR | [ ] Parameter comment must start with a capital letter
 159 | ERROR | [ ] Parameter comment must start with a capital letter
 161 | ERROR | [ ] Parameter comment must start with a capital letter
 207 | ERROR | [x] Additional blank lines found at end of doc comment
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------

Can you write the tests if possible ?

Best regards

Regarding tests: You mean test for user entity and test for negate option? I am not very experienced with writing tests. That might take some time.

Not problem, I will write the tests,

Best regards

Hi,

Creating a patch for solving PHPCS issue as suggested in #13 comment.

Please review the patch.

Thanks.

Hi,

I took the patch of stefan.korn and i fixed the phpstan, phpmd et phpcs.
I have created tests for the paragraphs on a user and for the inclusion and exclusion part.

Can you check please ?

Thanks.

Humm yes, you're right !

It should be good now !

Thank you Stefan and Bastien