Problem/Motivation

Cannot connect to the TMS when the site uses HTTPS.

Steps to reproduce

This to connect with HTTPS.

Proposed resolution

Don't use a cookie.

Remaining tasks

User interface changes

None.

API changes

Data model changes

CommentFileSizeAuthor
#8 3196847-handshake-without-cookie-8.patch10.63 KBpenyaskito
#8 3196847-handshake-without-cookie.interdiff.6-8.txt962 bytespenyaskito
#6 3196847-handshake-without-cookie-6.patch10 KBpenyaskito
#6 3196847-handshake-without-cookie.interdiff.4-6.txt3.17 KBpenyaskito
#4 3196847-handshake-without-cookie-4.patch7.71 KBpenyaskito
#4 3196847-handshake-without-cookie.interdiff.2-4.txt3.03 KBpenyaskito
#2 3196847-handshake-without-cookie.patch4.97 KBpenyaskito

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3196847-handshake-without-cookie.patch4.97 KB

Attached patch.

Status: Needs review » Needs work

The last submitted patch, 2: 3196847-handshake-without-cookie.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 3196847-handshake-without-cookie.interdiff.2-4.txt3.03 KB
new 3196847-handshake-without-cookie-4.patch7.71 KB

This should fix the tests.

Status: Needs review » Needs work

The last submitted patch, 4: 3196847-handshake-without-cookie-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 3196847-handshake-without-cookie.interdiff.4-6.txt3.17 KB
new 3196847-handshake-without-cookie-6.patch10 KB

Fixing remaining tests.

Status: Needs review » Needs work

The last submitted patch, 6: 3196847-handshake-without-cookie-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 3196847-handshake-without-cookie.interdiff.6-8.txt962 bytes
new 3196847-handshake-without-cookie-8.patch10.63 KB

Fix the last one.

penyaskito credited hlopez.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Hector reviewed this.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Committed 76f115d and pushed to 3.6.x. Thanks!
Cherry-picked c9f6752 and pushed to 3.5.x. Thanks!
Cherry-picked b80db29 and pushed to 3.4.x. Thanks!

  • penyaskito committed 76f115d on 3.6.x 
    Issue #3196847 by penyaskito, hlopez: Cannot connect to the TMS when the...

  • penyaskito committed c9f6752 on 3.5.x 
    Issue #3196847 by penyaskito, hlopez: Cannot connect to the TMS when the...

  • penyaskito committed b80db29 on 3.4.x 
    Issue #3196847 by penyaskito, hlopez: Cannot connect to the TMS when the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.