Problem/Motivation

Noticed this while reviewing #3191468: Retire "Admin UI and JavaScript Modernisation" initiative in favour of "Decoupled menus" and the upcoming "Easy out of the box" initiative. The Drupal 9 MAINTAINERS.txt file refers to "subsystem maintainers for Drupal 8" and "initiative coordinators for Drupal 8".

Proposed resolution

Remove the references to Drupal 8 so that the file is forward-compatible with Drupal 9 and 10.

CommentFileSizeAuthor
#11 maintainers-3195277-11.patch1018 bytesxjm
d9-actually.patch1.02 KBxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Haven't looked at maintainters.txt in a while so I applied the patch and read through it. This removes all references to the version of Drupal.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Note that this was already covered in #3191699: MAINTAINERS.txt role descriptions outdated, topic maintainer description missing, provisional maintainership incorrect that @xjm already reviewed along with other problems in the same areas such as the incorrect community initiatives link in the strategic initiatives section that is visible in the last hunk.

So I believe this is a duplicate of that issue.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Reviewed & tested by the community » Closed (duplicate)
Related issues: +#3191699: MAINTAINERS.txt role descriptions outdated, topic maintainer description missing, provisional maintainership incorrect

I looked at the MR for #3191699: MAINTAINERS.txt role descriptions outdated, topic maintainer description missing, provisional maintainership incorrect and this patch is a subset of those changes. Gábor Hojtsy, is correct this is a duplicate.

So changing the status.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

IMO the changes in #3191699: MAINTAINERS.txt role descriptions outdated, topic maintainer description missing, provisional maintainership incorrect are not well-scoped, but not a big enough deal to push back.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

How would scoping be better? For example the last hunk in this patch has a link to community initiatives, not strategic initiatives which makes governance definition confusing / incorrect. One could say it's the same "people can figure it out" as Drupal 8 vs 9 but probably more confusing. Should that be its own issue? Also, the missing description of topic maintainers should be its own issue? What would be best?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented 
+++ b/core/MAINTAINERS.txt
@@ -512,7 +512,7 @@ Initiative coordinators
 https://www.drupal.org/community-initiatives/drupal-core for more information on
-their responsibilities. The initiative coordinators for Drupal 8 are:
+their responsibilities. The initiative coordinators are:

Speaking of the first two lines here. The linked page neither lists the initiatives listed in MAINTAINERS.txt nor explains the responsibility of *anyone*, especially not the responsibilities of the people listed below. Should that be its own issue? I had that in #3191699: MAINTAINERS.txt role descriptions outdated, topic maintainer description missing, provisional maintainership incorrect because it was fixing the role description very similar to how the "Drupal 8" part was incorrect.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Closed (duplicate) » Reviewed & tested by the community

The scoping discussions in #3191699: MAINTAINERS.txt role descriptions outdated, topic maintainer description missing, provisional maintainership incorrect did not work out, so reopening this for commit.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

The patch doesn't apply.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
maintainers-3195277-11.patch1018 bytes
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Reviewed & tested by the community

Reroll looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 2dd332b788 to 9.2.x and 46cb915a39 to 9.1.x. Thanks!

  • alexpott committed 2dd332b on 9.2.x 
    Issue #3195277 by xjm, Gábor Hojtsy, quietone: Drupal 9 MAINTAINERS.txt...

  • alexpott committed 46cb915 on 9.1.x 
    Issue #3195277 by xjm, Gábor Hojtsy, quietone: Drupal 9 MAINTAINERS.txt...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.