Problem/Motivation

There are several repeat problems in MAINTAINERS.txt:

  • Two maintainer role descriptions mention Drupal 8
  • There is an outdated link that moved (even through redirects, we can use the updated one)
  • The initiatives responsibilities link is incorrect, it links to community initiatives rather than strategic ones and either way neither of those pages list the responsibilities of the initiative leads
  • Even though every other section has a short description, topic maintainers don't.
  • Provisional memberships says "none at this time" at two places, where it is not true. This was #3187927: Make provisional maintainership appear consistently in MAINTAINERS.txt, but IMHO easier to fix at once.
  • Section separation is at one point 3 empty lines and all other points 2 empty lines.

Proposed resolution

Fix these. Copied the topic maintainer description from the governance page without listing the topics again, since they are listed below.

Remaining tasks

Review.

Issue fork drupal-3191699

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gábor Hojtsy created an issue. See original summary.

Gábor Hojtsy credited ChrisDarke.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: MAINTAINERS.txt maintainer roles mention Drupal 8, have incorrect links and topic maintainer description missing » MAINTAINERS.txt role descriptions outdated, topic maintainer description missing, provisional maintainership incorrect
Issue summary: View changes

Let's fold in provisional maintainership fixing too. So merging in #3187927: Make provisional maintainership appear consistently in MAINTAINERS.txt.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

Gábor Hojtsy opened merge request !229

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Needs work

I didn't think about this when commenting on the MR, but from my perspective this is NW to either format the provisional maintainership in the way that was originally intended, or remove it everywhere.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review

In my reading the only remaining note about lack of provisional maintainers at the bottom of the initiative coordinators section was well placed since none of the initiatives had provisional maintainers. But I am fine removing if that's an improvement. Changed in the MR.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I don't quite understand why did these commits get included in the MR, looking at the git graph for the branch (https://git.drupalcode.org/project/drupal/-/network/3191699-maintainers....), the branch properly contains the two commits I made only from an updated 9.2.x branch. Also, when editing the MR at https://git.drupalcode.org/project/drupal/-/merge_requests/229/edit it does reflect it is between the branch that is only 2 commits away from project/drupal:9.2.x.

Gábor Hojtsy opened merge request !276

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Opened https://git.drupalcode.org/project/drupal/-/merge_requests/276 because I could not figure out how to resolve the rebase problems with https://git.drupalcode.org/project/drupal/-/merge_requests/229.

Gábor Hojtsy closed merge request !229

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Closed (duplicate)

I was sincerely hoping this will be a trivial issue. As for scope, it is misc minor text changes. People keep opening the same issues like #3195951: Remove "Provisional membership: None at this time" texts from MAINTAINERS.txt, so in the interest of getting this done, I did the following:

  1. Reopened #3195277: Drupal 9 MAINTAINERS.txt talks about Drupal 8 at RTBC.
  2. Set #3195951: Remove "Provisional membership: None at this time" texts from MAINTAINERS.txt needs work since it needs to remove all instances and interlinked that with the previous #3187927: Make provisional maintainership appear consistently in MAINTAINERS.txt
  3. Opened #3196388: Incorrect link for initiative responsibilities in MAINTAINERS.txt and posted the respective snippet of this change there.
  4. Opened #3196391: Inconsistent capitalisation for initiative leaders in MAINTAINERS.txt and posted the respective snippet of this change there.
  5. Opened #3196392: Topic maintainers lack a description in MAINTAINERS.txt and posted the respective snippet of this change there.

Going to skip opening an issue about the whitespace fix. That should cover all of the parts of this issue, so we can discuss them in isolation rather than in one issue.