The URLSearchParams object in url-parser.js is not compatible with IE11 and needs to be polyfilled or replaced.

CommentFileSizeAuthor
#5 3194870-5.patch2.45 KBgantal
#2 3194870-2.patch917 bytesPooja Ganjage

Comments

gantal created an issue. See original summary.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3194870-2.patch917 bytes

Hi,

Creating a patch for this issue.

Please review the patch.

Let me know if any suggestions.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
gantal’s picture

gantal commented
Status: Needs review » Needs work

Thanks for the patch, @Pooja Ganjage. The function you added in the patch does seem like it could be used to replace URLSearchParams but the rest of the mapValues function will need to change as well. As it stands, Smart Content does not show correct results with this patch applied.

gantal’s picture

gantal commented
Status: Needs work » Needs review
StatusFileSize
new 3194870-5.patch2.45 KB

Adding new patch which adds an external library: https://github.com/ungap/url-search-params to polyfill. The package seems to be the de facto polyfill for URLSearchParams.

  • gantal committed 5dbc115 on 1.0.x 
    Issue #3194870 by gantal, Pooja Ganjage: Polyfill or replace...
gantal’s picture

gantal commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.