Problem/Motivation

  • Implement OpenStackService to use OpenStack native API for Launch Templates List and Operations
CommentFileSizeAuthor
#16 3190078-16.patch40.61 KBjigish.addweb
#14 3190078-14.patch40.32 KBjigish.addweb
#12 3190078-12.patch39.32 KBjigish.addweb
#9 3190078-9.patch37.7 KBjigish.addweb
#8 dev1.dataninja.net_clouds_design_server_template_dii_regionone_openstack_add.png328.07 KByas
#6 3190078-6.patch36.09 KBjigish.addweb
#5 3190078-5.patch36.22 KBjigish.addweb
#4 3190078-4.patch42.16 KBjigish.addweb
#3 3190078-3.patch34.89 KBjigish.addweb

Issue fork cloud-3190078

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb opened merge request !82

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190078-3.patch34.89 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190078-4.patch42.16 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190078-5.patch36.22 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190078-6.patch36.09 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review

@yas

Please review the latest patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new dev1.dataninja.net_clouds_design_server_template_dii_regionone_openstack_add.png328.07 KB

@jigishaddweb

I reviewed the patch. Please see my above comment. Also, I couldn't see any flavor in Launch Template creation form.

Also, can you remove hyphen (-) from the list of the Network Interfaces?

add.png

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190078-9.patch37.7 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

Done with your suggested changes, and uploaded refactored patch,

Please review.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for the update.

My comment is unresolved.

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190078-12.patch39.32 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190078-14.patch40.32 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for the update. Please see my above comments.

Thanks

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3190078-16.patch40.61 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. I tested the patch and it looks good to me. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed 8a92fca on 3.x authored by jigish.addweb 
    Issue #3190078 by jigish.addweb, yas: Implement OpenStackService to use...

yas closed merge request !82

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.