Problem/Motivation
I suggest hiding the youtube logo and the preloader for the remote video (Youtube) in case the video is still buffering.
Steps to reproduce
Given that having a FHD YouTube video with slow internet
And the slide's video needed to buffer data before autoplay
When the page loads
Then the preloader will show up to users
Proposed resolution
Keep the video hidden until it starts playing the video so we can show it then.
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ Accessibility and Readability
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release Varbase 9.0.9, varbase_heroslider_media-9.0.6
Varbase update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- No seeing the Youtube logo while loading the remote video
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Issue #3189408 by Odai Atieh, mahseri: Hide preloader for remote video YouTube
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3189408-7.patch | 927 bytes | mahseri |
| #2 | 3189408-2.patch | 925 bytes | odai atieh |
Comments
Comment #2
odai atiehComment #3
odai atiehComment #5
rajab natshahComment #6
rajab natshahComment #7
mahseri commentedComment #8
rajab natshahComment #11
rajab natshahComment #12
rajab natshahComment #13
rajab natshahComment #14
rajab natshah✅ Released varbase_heroslider_media-9.0.6
Comment #15
rajab natshah✅ Released Varbase 9.0.9