Problem/Motivation

I suggest hiding the youtube logo and the preloader for the remote video (Youtube) in case the video is still buffering.

Steps to reproduce

Given that having a FHD YouTube video with slow internet
And the slide's video needed to buffer data before autoplay
When the page loads
Then the preloader will show up to users

Proposed resolution

Keep the video hidden until it starts playing the video so we can show it then.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 9.0.9, varbase_heroslider_media-9.0.6

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • No seeing the Youtube logo while loading the remote video

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

CommentFileSizeAuthor
#7 3189408-7.patch927 bytesmahseri
#2 3189408-2.patch925 bytesodai atieh

Comments

Odai Atieh created an issue. See original summary.

odai atieh’s picture

StatusFileSize
new925 bytes
odai atieh’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3189408-2.patch, failed testing. View results

rajab natshah’s picture

Status: Needs work » Needs review
rajab natshah’s picture

Version: 8.x-7.x-dev » 9.0.x-dev
Issue summary: View changes
mahseri’s picture

StatusFileSize
new927 bytes
rajab natshah’s picture

  • Rajab Natshah committed f49f766 on 9.0.x
    Issue #3189408 by Odai Atieh, mahseri: Hide preloader for remote video...

  • Rajab Natshah committed bae4bd9 on 10.0.x
    Issue #3189408 by Odai Atieh, mahseri: Hide preloader for remote video...
rajab natshah’s picture

Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Issue tags: +varbase-9.0.9, +varbase_heroslider_media-9.0.6
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released Varbase 9.0.9

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.