Closed (fixed)
Project:
Hierarchy Manager
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Dec 2020 at 13:10 UTC
Updated:
19 Jan 2021 at 23:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dench0Here the patch.
Comment #3
dench0Comment #4
dench0Little bit fixed patch.
Comment #5
mingsongThanks Denis for the suggestion which is very interesting.
Can anyone review and test it?
Comment #6
elgandoz commentedThis patch not only has a cleaner and better approach, but it also fixes the issue of broken behaviour applied to the taxonomy dialog (see before/after screenshot) which was making this module not usable on complex taxonomy form.
Usability wise is also a major improvement, avoiding several forms opened at once, which was looking messy on some admin theme (e.g. Claro).
There is still a problem with the action button inside the modal, they get moved in the modal footer: this is ok for the main "Save" and "Delete" but not for other (e.g. when the taxonomy has a paragraphs or any sub-form).Edit: This seems related to Claro since it works perfectly with Seven, see Core issue #3151534.Patch #4 was not applying with composer-patches for me neither on 2.0 nor 2.x-dev (whitespaces): I rerolled the patch with no code changes (for some reason it throws an error while trying to generate the interdiff). The javascript may be better formatted following Drupal coding standards (whitespaces and nesting level).
This is a great module which may need some policing to make it extraordinary useful.
Comment #7
elgandoz commentedComment #8
mingsongThanks Denis and Marco for the excellent works.
It looks good to me.
Comment #10
mingsongI tested the PR in my local site and it is working as expected.
Comment #12
mingsongComment #13
mingsongReleased with 2.0.1