Problem/Motivation

I suggest to use the standard Ajax Links for the opening edit term/menu dialogs.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dench0 created an issue. See original summary.

dench0’s picture

Status: Active » Needs review
StatusFileSize
new3.2 KB

Here the patch.

dench0’s picture

Title: Use Drupal Dialog API. » Ajax Links for the dialog opening.
dench0’s picture

StatusFileSize
new3.15 KB

Little bit fixed patch.

mingsong’s picture

Thanks Denis for the suggestion which is very interesting.

Can anyone review and test it?

elgandoz’s picture

Status: Needs review » Needs work
StatusFileSize
new3.2 KB
new254.56 KB
new150.13 KB
new172.49 KB

This patch not only has a cleaner and better approach, but it also fixes the issue of broken behaviour applied to the taxonomy dialog (see before/after screenshot) which was making this module not usable on complex taxonomy form.

Usability wise is also a major improvement, avoiding several forms opened at once, which was looking messy on some admin theme (e.g. Claro).

There is still a problem with the action button inside the modal, they get moved in the modal footer: this is ok for the main "Save" and "Delete" but not for other (e.g. when the taxonomy has a paragraphs or any sub-form). Edit: This seems related to Claro since it works perfectly with Seven, see Core issue #3151534.

Patch #4 was not applying with composer-patches for me neither on 2.0 nor 2.x-dev (whitespaces): I rerolled the patch with no code changes (for some reason it throws an error while trying to generate the interdiff). The javascript may be better formatted following Drupal coding standards (whitespaces and nesting level).

This is a great module which may need some policing to make it extraordinary useful.

elgandoz’s picture

Status: Needs work » Needs review
mingsong’s picture

Thanks Denis and Marco for the excellent works.

It looks good to me.

mingsong’s picture

Status: Needs review » Reviewed & tested by the community

I tested the PR in my local site and it is working as expected.

  • dench0 authored 0869891 on 2.x
    Issue #3188871 by dench0, elgandoz, Mingsong:  Ajax Links for the dialog...
mingsong’s picture

Status: Reviewed & tested by the community » Fixed
mingsong’s picture

Released with 2.0.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.