Problem/Motivation

templates/views-view-fullcalendar.html.twig

There is this code : 

<div id="bottom-buttons fc-button-group">
{% if showAddEvent %}

And a ID can't have white space

Proposed resolution

Add class and up the test 

{% if showAddEvent %}
<div id="bottom-buttons" class="fc-button-group">

Issue fork fullcalendar_view-3186452

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

robby78 created an issue. See original summary.

Mingsong made their first commit to this issue’s fork.

Mingsong opened merge request !6

mingsong’s picture

mingsong
Location 🇦🇺
commented

Thanks Robby.

Good pick up.

I think it would be better to use 'class' instead of 'id', as there might be multiple calendar view in one page.

  • Mingsong authored f78a53f on 5.x 
    Issue #3186452 by Mingsong, robby78: Bad HTML ID
mingsong’s picture

mingsong
Location 🇦🇺
commented
Status: Active » Patch (to be ported)

Merged.

mingsong’s picture

mingsong
Location 🇦🇺
commented
Status: Patch (to be ported) » Fixed
mingsong’s picture

mingsong
Location 🇦🇺
commented

Released with 5.0.6

robby78’s picture

robby78 commented
Priority: Normal » Minor
Status: Fixed » Closed (fixed)

Hello, thks for the correction