Attached patch adds schema for field.widget.settings.* for the paragraphs browser widgets. A better approach would be to merge the parent class schema (e.g. 'type: paragraphs') with the extra keys this module provides (paragraphs_browser, modal_width, modal_height) but I didn't know how to do that.

CommentFileSizeAuthor
#11 paragraphs_browser-n3187363-8.patch2.15 KBdamienmckenna
#3 3186190-paragraphs_browser-add_widget_schema-3.patch1.7 KBbgilhome
#2 3186190-paragraphs_browser-add_widget_schema-2.patch1.5 KBbgilhome
paragraphs_browser-add_widget_schema.patch1.42 KBbgilhome

Issue fork paragraphs_browser-3186190

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bgilhome created an issue. See original summary.

bgilhome’s picture

bgilhome commented
StatusFileSize
new 3186190-paragraphs_browser-add_widget_schema-2.patch1.5 KB

Rerolled.

bgilhome’s picture

bgilhome commented
StatusFileSize
new 3186190-paragraphs_browser-add_widget_schema-3.patch1.7 KB

Forgot schema for third party settings, updated patch attached.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work

These look good on surface inspection, but since it's been 5 years since this was created I am not sure if anything changed in the meanwhile.

Can we maybe start with creating a merge request from this?

shamir.vs made their first commit to this issue’s fork.

shamir.vs opened merge request !23

shamir.vs’s picture

shamir.vs commented
Status: Needs work » Needs review

I have created a merge request. Please take a moment to review it. Thank you!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

I am not 100% sure that these are all the possible keys that the schema can have, can we double check that as well?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Category: Support request » Task
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3187363: Fill schema for maps/groups keys
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new paragraphs_browser-n3187363-8.patch2.15 KB

This combines the MR with #3187363: Fill schema for maps/groups keys.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

With #11 the last bit needed is to spec out this part:

    map:
      label: 'Map'
      type: sequence
      sequence:
        type: undefined
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work