Problem/Motivation

In #3183420: Override \Behat\Mink\Driver\Selenium2Driver::uploadFile() in DrupalSelenium2Driver we overrode \Behat\Mink\Driver\Selenium2Driver::attachFile() to fix a PHP 8 bug. Once https://github.com/minkphp/MinkSelenium2Driver has a new release we can remove the override

Proposed resolution

Remove the override.

Remaining tasks

User interface changes

NOne

API changes

None

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#7 3183423-7.patch1.46 KBimmaculatexavier

Comments

alexpott created an issue. See original summary.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Status: Postponed » Active

There has been a release since this was opened and MinkSelenium2Driver is being tested on 8.0 and 8.1. Setting to Active.

immaculatexavier’s picture

Status: Active » Needs review
StatusFileSize
new1.46 KB

Attached patch in accordance to the proposed resolution

andypost’s picture

Status: Needs review » Reviewed & tested by the community

Looks ready to go

  • catch committed b93e50c on 10.0.x
    Issue #3183423 by immaculatexavier, alexpott, quietone: Remove \Drupal\...
  • catch committed 22ef85d on 10.1.x
    Issue #3183423 by immaculatexavier, alexpott, quietone: Remove \Drupal\...
  • catch committed 0f76e62 on 9.5.x
    Issue #3183423 by immaculatexavier, alexpott, quietone: Remove \Drupal\...
catch’s picture

Version: 10.1.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked back through to 9.5.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.