Unfortunately \Behat\Mink\Driver\Selenium2Driver::uploadFile() triggers a deprecation notice on PHP 8. We've been waiting on a release of https://github.com/minkphp/MinkSelenium2Driver for a while but it's not happened.
However we've fixed the same bug in DrupalSelenium2Driver in #3174038: ZipArchive::open(): Using empty file as ZipArchive is deprecated in PHP 8 so we can use our code instead.
Override \Behat\Mink\Driver\Selenium2Driver::attachFile() and call \Drupal\FunctionalJavascriptTests\DrupalSelenium2Driver::uploadFileAndGetRemoteFilePath() instead of \Behat\Mink\Driver\Selenium2Driver::uploadFile() (we can't override uploadFile() because it is private)
None
None
None
N/a
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3183420-2.patch | 1.45 KB | alexpott |
Comments
Comment #2
alexpottSee #3156595-135: Make Drupal 9 installable on PHP8 for successful PHP 8 JS testing with this patch applied.
Comment #3
alexpottCreated a postponed follow to remove once we have a new release of Selenium2Driver... #3183423: Remove \Drupal\FunctionalJavascriptTests\DrupalSelenium2Driver::attachFile() once upstream dependency has a new release
Comment #4
catchGood plan.
Comment #5
MixologicWe've been stuck waiting on this particular upstream library for a release for years in the past. This isn't ideal, but vastly preferable to waiting on them to act.
Comment #7
effulgentsia commentedPushed to 9.2.x.
Since 9.1 is in RC, leaving at RTBC for a release manager to decide whether to cherry pick to 9.1.
Comment #8
alexpott+1 for backport - even if core is not technically PHP 8 compatible on 9.1.0 release the parts that won't be ie. the laminas dependencies are barely used. Having this patch in 9.1 will help people run JS tests without unnecessary fails.
Also this is test only code by definition.
Comment #10
catchAgreed, very low risk and can't be overridden with --ignore-platform-reqs.