Problem/Motivation

drupalPostForm is deprecated
See: https://www.drupal.org/node/3168858

CommentFileSizeAuthor
#11 3183280-11.patch3.81 KBraman.b
#9 3183280-9.patch4.08 KBpaulocs
#7 3183280-7.patch4.68 KBPooja Ganjage
#4 3183280-3.patch4.55 KBPooja Ganjage
#2 3183280-2.patch3.95 KBpaulocs

Comments

paulocs created an issue. See original summary.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Assigned: paulocs » Unassigned
Status: Active » Needs review
StatusFileSize
new 3183280-2.patch3.95 KB

A patch for it.

Status: Needs review » Needs work

The last submitted patch, 2: 3183280-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3183280-3.patch4.55 KB

Hi,

Creating a patch as fixes coding standard issue occurred in #2 patch.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 3183280-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3183280-7.patch4.68 KB
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Assigned: Unassigned » paulocs
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Assigned: paulocs » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3183280-9.patch4.08 KB

A patch for it.

Just a tip @Pooja Ganjage: if you already know that the tests are falling, you should run it locally before you attach a new patch.

adamps’s picture

adamps commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

What happened is that #2223967: Do not decode a contact message twice recently got fixed, hence the @todo in RealMailTest.php suddenly needed to be done.

The fix for this was then committed in #3182622: Fix 2.x branch tests. Unfortunately that means this needs another reroll please.

raman.b’s picture

raman.b commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3183280-11.patch3.81 KB

Re-rolling patch from #9

  • webflo committed 9f537ee on 8.x-2.x authored by raman.b 
    Issue #3183280 by paulocs, Pooja Ganjage, raman.b: drupalPostForm in...
webflo’s picture

webflo commented
Status: Needs review » Fixed

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.