Problem/Motivation

Reported and provided by Yasmeen

Varbase media header do we have the option to display the default drupal breadcrumbs block
I need to display the breadcrumb below the media header

Steps to reproduce

Proposed resolution

  • Proposed by Yasmeen: Adding checkbox config to allow the user to hide the breadcrumbs from varbase media header

Other options listed by Rajab

We do have something like 3 types of general configs for the Varbase Media Header

  1. Varbase Media header setting page. The list of content types with activated options.
  2. Varbase Media Hader Block to select which media field to use for the header media. and to place the block in the desired region.
  3. Editor Content option to select the style of Media Header or Standard ( or more in the list if added ).

More General or Default styling configs could be added to support other Default Style in the 3 types

  1. About the settings page for Varbase Media Header ( Not with adding more config/ general default setting in this option to effect all the site )
  2. More Block options next to each content type. ( With this option for selecting the default style ) With this option - for selecting the default media header option not to do this on each edit of content. ( It could be changed in the media header styling option field settings in the content type)
  3. The Media Header styling option filed in the content. was made to add new styling templates.. it will point to the twig template file ( We may go and do this in each project if needed) Strongly with this option - Only add more default media header styles, we could copy them from projects. to let other projects use them in a quick time.


Wanted to do the config for each activated content type.

I’m convinced that this is the simplest solution.

Agreed with Razem

User interface changes

When Default breadcrumbs option is not checked

When Default breadcrumbs option is not checked

When Default breadcrumbs option is checked

When Default breadcrumbs option is checked


Root Section - When Default breadcrumbs option is not checked

Root Section - When Default breadcrumbs option is not checked

Root Section - When Default breadcrumbs option is checked

Root Section - When Default breadcrumbs option is checked


Test Basic Page #1 title with Varbase Media Header and Breadcrumbs - When Default breadcrumbs option is not checked

Test Basic Page #1 title with Varbase Media Header and Breadcrumbs - When Default breadcrumbs option is not checked

Test Basic Page #1 title with Varbase Media Header and Breadcrumbs - When Default breadcrumbs option is checked

Test Basic Page #1 title with Varbase Media Header and Breadcrumbs - When Default breadcrumbs option is checked

Root Section for standard Page header style


API changes

None

Data model changes

Add new Schema Config default_breadcrumbs

Drush updb is needed or go to "/update.php"

Comments

yasmeensalah created an issue. See original summary.

yasmeensalah’s picture

rajab natshah’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: ability-to-hide-breadcrumbs-3180926-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

rajab natshah’s picture

Status: Needs work » Needs review
rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Status: Needs review » Active
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

StatusFileSize
new4.84 KB

  • RajabNatshah committed 00f29e9 on 9.0.x
    Issue #3180926: Add the ability to hide the breadcrumbs from Varbase...

  • RajabNatshah committed a654f62 on 8.x-7.x
    Issue #3180926: Add the ability to hide the breadcrumbs from Varbase...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review
Issue tags: +varbase-8.8.8, +varbase-9.0.0, +varbase-9.0.0-rc1
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Needs work

Feedback by Razem

Change title to:
Hide breadcrumbs

Change description to:

Choosing this option will prevent the breadcrumbs from appearing in the Media Header automatically. You can still control where the breadcrumbs appear using the normal block placement from <a href=“LINK TO /admin/structure/block”>Block layout</a> page.

Change default_breadcrumbs to hid_breadcrumbs

rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Status: Needs work » Active
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Title: Add the ability to hide the breadcrumbs from Varbase Media Header » Add the ability to hide breadcrumbs from the Media Header

  • RajabNatshah committed eb7dd5b on 8.x-7.x
    Issue #3180926: Add the ability to hide breadcrumbs from the Media...

  • RajabNatshah committed a642946 on 9.0.x
    Issue #3180926: Add the ability to hide breadcrumbs from the Media...
rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new176.95 KB
new178.56 KB

rajab natshah’s picture

Issue summary: View changes
StatusFileSize
new366.02 KB

Drush updb is needed or go to "/update.php"

  • RajabNatshah committed 7a85d4f on 8.x-7.x
    Issue #3180926: Add the ability to hide breadcrumbs from the Media...

  • RajabNatshah committed dd6ce2f on 9.0.x
    Issue #3180926: Add the ability to hide breadcrumbs from the Media...
rajab natshah’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.