Running upgrade status on this module produces a warning:

modules/contrib/cache_control_override/tests/modules/cache_control_override_test/cache_control_override_test.info.yml 

Add core_version_requirement: ^8 || ^9 to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.
CommentFileSizeAuthor
#5 interdiff-2-5.txt385 bytesmstrelan
#5 3180748-5.patch1.14 KBmstrelan
#2 3180748-2.patch650 bytesacbramley

Issue fork cache_control_override-3180748

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bdanin created an issue. See original summary.

acbramley’s picture

acbramley commented
Status: Active » Needs review
StatusFileSize
new 3180748-2.patch650 bytes

This will fix that. Test modules can avoid core or core_version_requirement keys by marking the module as a Testing package.

bdanin’s picture

bdanin commented

This patch is working for me.

bdanin’s picture

bdanin commented
Status: Needs review » Reviewed & tested by the community
mstrelan’s picture

mstrelan commented
Version: 8.x-1.0-alpha2 » 8.x-1.x-dev
Priority: Major » Normal
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3180748-5.patch1.14 KB
new interdiff-2-5.txt385 bytes

I'm hijacking this issue to add that the test needs a $defaultTheme as per https://www.drupal.org/node/3083055

acbramley’s picture

acbramley commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC for the changes in #5 look good!

dpi made their first commit to this issue’s fork.

dpi opened merge request !4

dpi’s picture

dpi
Location Perth, Australia
commented

  • dpi committed ce442b4 on 8.x-1.x 
    Issue #3180748 by dpi, mstrelan, acbramley, bdanin: Drupal 9...
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Reviewed & tested by the community » Fixed

merged to 1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.