Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Not a real problem but I added for myself an height option in .\leaflet\src\LeafletSettingsElementsTrait.php
Added 'vh' => t('vh'),
within options for $elements['height_unit'] element
line 155 in attached file
Steps to reproduce
N/A
Proposed resolution
Apply entry (even if not a resolution as such)
Remaining tasks
N/A
User interface changes
N/A
API changes
N/A
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3180537-9.patch | 662 bytes | nwom |
Comments
Comment #2
nwom commentedThanks for your work! Here is a patch based on it.
Comment #3
nwom commentedComment #4
nwom commentedThere was a spacing issues on one of the lines. Fixed it really quick. Please review.
Comment #5
itamair commentedsure about this patch NWOM????
I can see this in your patch ...
and it looks you are messing code from GeofieldMap into Leaflet ... isn't it?
Please, make sure all this works for you without GeofieldMap ...
Comment #6
itamair commentedAlso it looks you are changing
public static function getDefaultSettings()values without special reasons ...Patch definitely rejected on this form.
Please clean it up of all those useless changes to the existing code, make sure not to introduce regressions (!!!).
and also describe why this additional functionality should be considered and merged into the Leaflet code
(what functionalities is it achieving, in which user case?)
Comment #7
nwom commented@itamair: This isn't my work. This is a patch based on the php file that @Civette posted (Show hidden files). I have not tested it myself. Just doing my due diligence, and wanted to test it next week. So please direct all of your questions at Civette ;)
Thanks for the feedback though. Now I'll avoid testing it until those problems are solved as well.
Comment #8
nwom commentedDeleted (not sure why it posted my comment twice)
Comment #9
nwom commentedAh it looks like Civette mentioned that the changes were referenced only at
line 155according to their description, so the rest of the changes in their file have nothing to do with the Feature Request.Here is an updated patch in that case. Also to clarify why this feature request makes sense: It lets you create a map based on the vertical height of the viewport, rather than % or px.
Again, I haven't tested the functionality, just porting the work that Civette did into a patch in order to apply via Composer, etc; in order to help others easily test this.
Comment #10
nwom commentedComment #12
itamair commentedCommitted into dev and deployed as new 2.1.12 release