Closed (fixed)
Project:
Bootstrap
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Oct 2020 at 05:22 UTC
Updated:
28 Sep 2021 at 16:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
joelpittetI've only seen this since moving to PHP 7.4, not sure the culprit yet.
Comment #3
dippers commentedSee https://www.drupal.org/project/drupal/issues/3084961.
The part of the patch for theme_pager() also needs to be applied to bootstrap_pager().
Comment #4
dippers commentedPatch attached.
Comment #5
joelpittetThanks that looks reasonable, my digging didn’t find the source week enough except fontawesome and icon had an issue that I could decipher
Comment #6
akhilavnairHi, Could you please merge this patch with latest version
Comment #7
lucatrabx commentedwhere i have to put it?
Comment #8
fenstrat+1 RTBC, also only saw this when updating to PHP 7.4.
Comment #9
maxmendez commentedThe patch 4 fixed my problem, but i've added a line to update $quantity based on theme_pager function.
Note: I got confused, sorry for the first comment.
Comment #10
ressaThanks @Dippers and @MaxMendez, I am also seeing these warnings. I am changing Status to trigger testing and alert the maintainers.
Comment #12
ressaIt looks like Automated testing is not enabled for this project, so the patch in #9 doesn't get tested.
I created a patch via Drupal's Gitlab integration, which seems to get registered and checked for mergeability, but not tested.
Comment #15
markhalliwell