Problem/Motivation

Having the Mark all updates by the update helper checklist as successful on install.
https://git.drupalcode.org/project/varbase/-/blob/8.x-8.x/varbase.profil...

But when we enable optional Varbase components the site will show up the "Optional Update config" as a "Pending updates".

Steps to reproduce

Given that Varbase had been installed with only the default components.
When an optional Varbase component been enabled in the site or in a Varbase Sub Profile
Then the "Pending updates" should not show up
Pending updates for Varbase update instructions


In the database, optional updates entities are not in the database

But when we enable optional modules they do not show up a status too
And then when we check in the checklist they will be present in the database

Proposed resolution

Mark all updated configs as a successful update
Even if the updated config was an optional one

Remaining tasks

  • Fix logic for not enabled Varbase components
  • Test on the install of Varbase
  • Test on the install of Varbase sub-profile
  • Release

User interface changes

Not to show "Pending updates" after installing an optional Varbase component

API changes

None

Data model changes

None

Comments

RajabNatshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

  • RajabNatshah committed c3ccf78 on 9.0.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...

  • RajabNatshah committed 3468f6b on 9.0.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...

  • RajabNatshah committed 706e1da on 9.0.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...

  • RajabNatshah committed 4702111 on 9.0.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...

  • RajabNatshah committed c67a43a on 9.0.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...

  • RajabNatshah committed 3e1c631 on 9.0.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...

  • RajabNatshah committed 8a7bbc6 on 9.0.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...

  • RajabNatshah committed d41dddf on 9.0.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...

  • RajabNatshah committed 95555ab on 8.x-8.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...
rajab natshah’s picture

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Assigned: Unassigned » rajab natshah

  • RajabNatshah committed 8428f1c on 8.x-8.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...

  • RajabNatshah committed f65ff7c on 9.0.x
    Issue #3179426: Fix status of Varbase update instructions to 100% on...
rajab natshah’s picture

rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.