Update Bootstrap library from 4.5.2 to 4.5.3 [#3178141]

CSS

#31653: Add a comment to our escape-svg function to note that data URIs must be quoted.
#31693: Use the custom-control shadow variable instead of the generic input-focus-box-shadow.
#31793: Backport some v5 changes (improved th styling in Reboot, custom form field styling when printing, and improvements to .text-break).
- #29714: Keep custom check, radio, and switch theme when printing.
- #30781: Reboot's th updates: Inherit font-weight: bold that comes from user agent stylesheets.
- #30932: .text-break changes to drop overflow-wrap and use word-wrap once again
- #31754: Improve versions page rendering (also reversed the order while I was here)
#31846: Backports the z-index change to .close buttons in dismissible .alerts.

JS

#31000: Avoid multiple change event trigger in buttons plugin. Not applicable to v5 since our button JS plugin has been mostly replaced with pure CSS.
#31673: Fix dropdown variable always evaluating to true.
#31696: Ensure hidePrevented.bs.modal can be prevented.
#31718: Backports new $dropdown-padding-x variable from v5.

Docs

#30811: Mention GPU acceleration fix in docs callout for popovers. Doesn't apply to v5 since we're updating to Popper v2.
#30838: Explain the dispose method more appropriately.
#31706: Backports updated margins for code snippets for improved readability.
#31769: Backports JS bundle guidance from v5.
#31851: Backports mention of missing to and nextwhenvisible methods.

Misc

#31297: Switch to xo ESLint config
Updated devDependencies versions

Comment	File	Size	Author
#9	bootstrap40503.png	112.4 KB	Rajab Natshah

Comments

Comment #1

21 October 2020 at 11:37

RajabNatshah created an issue. See original summary.

Comment #2

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 21 October 2020 at 11:39

Issue summary:

View changes

Comment #3

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 21 October 2020 at 11:44

Comment #4

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 21 October 2020 at 11:47

Comment #5

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 21 October 2020 at 11:51

Title:

Update Bootstrap library from 4.5.2 to 4.53

» Update Bootstrap library from 4.5.2 to 4.5.3

Comment #6

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 21 October 2020 at 12:16

Comment #7

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 21 October 2020 at 12:20

Comment #8

21 October 2020 at 16:29

RajabNatshah committed 5522466 on 8.x-6.x

Issue #3178141: Update Bootstrap library from 4.5.2 to 4.5.3

Comment #9

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 21 October 2020 at 16:50

File	Size
bootstrap40503.png	112.4 KB

Comment #10

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 21 October 2020 at 16:52

Assigned:	Rajab Natshah	» Mohammed J. Razem
Status:	Active	» Needs review
Issue tags:		+varbase-8.8.8, +varbase-9.0.0, +varbase-9.0.0-alpha1

Comment #11

Assigned:

Mohammed J. Razem

» Unassigned

Comment #12

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 21 October 2020 at 17:20

gulp compile

rajab@vardot-dev:/var/www/html/products/vartheme_bs4$ gulp compile
[19:54:39] Using gulpfile /var/www/html/products/vartheme_bs4/gulpfile.js
[19:54:39] Starting 'compile'...
[19:54:43] Finished 'compile' after 3.66 s

rajab@vardot-dev:/var/www/html/products/vartheme_bs4/VARTHEME_BS4_SUBTHEME$ gulp compile
[19:54:47] Using gulpfile /var/www/html/products/vartheme_bs4/VARTHEME_BS4_SUBTHEME/gulpfile.js
[19:54:47] Starting 'compile'...
[19:54:51] Finished 'compile' after 3.46 s

yarn phpcs

rajab@vardot-dev:/var/www/html/products/vartheme_bs4$ yarn phpcs
yarn run v1.22.5
$ phpcs --standard=./.phpcs.xml .
Done in 5.07s.

yarn phpcbf

rajab@vardot-dev:/var/www/html/products/vartheme_bs4$ yarn phpcbf
yarn run v1.22.5
$ phpcbf --standard=./.phpcs.xml .
<code>
No fixable errors were found

Time: 4.88 secs; Memory: 94.01MB

Done in 4.97s.

yarn eslint

rajab@vardot-dev:/var/www/html/products/vartheme_bs4$ yarn eslint
yarn run v1.22.5
$ node ./node_modules/eslint/bin/eslint.js --config=.eslintrc.json .
Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. Assuming latest React version for linting.
Done in 1.82s.

yarn stylelint

rajab@vardot-dev:/var/www/html/products/vartheme_bs4$ yarn stylelint
yarn run v1.22.5
$ npx stylelint --config=.stylelintrc.json .

css/base/bootstrap.base.css
 11780:3  ✖  Expected empty line before at-rule                  at-rule-empty-line-before
 11783:3  ✖  Expected rule to come before at-rule with a block   order/order              

VARTHEME_BS4_SUBTHEME/css/base/bootstrap.base.css
 11780:3  ✖  Expected empty line before at-rule                  at-rule-empty-line-before
 11783:3  ✖  Expected rule to come before at-rule with a block   order/order

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.