From @lauriii in #216 in #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

These are theme overrides.

+++ b/core/themes/olivero/templates/field/field--comment.html.twig
@@ -0,0 +1,57 @@
+ * Default theme override for comment fields.

+++ b/core/themes/olivero/templates/form--search-block-form.html.twig
@@ -0,0 +1,15 @@
+ * Default theme implementation for a 'form' element.

+++ b/core/themes/olivero/templates/form/field-multiple-value-form.html.twig
@@ -0,0 +1,50 @@
+ * Default theme implementation for an individual form element.

+++ b/core/themes/olivero/templates/menu-local-action.html.twig
@@ -0,0 +1,17 @@
+ * Default theme implementation for a single local action link.

+++ b/core/themes/olivero/templates/navigation/toolbar.html.twig
@@ -0,0 +1,51 @@
+ * Default theme implementation for the administrative toolbar.

+++ b/core/themes/olivero/templates/user/user--compact.html.twig
@@ -0,0 +1,25 @@
+ * Default theme implementation to present all user data.

+++ b/core/themes/olivero/templates/user/username.html.twig
@@ -0,0 +1,31 @@
+ * Default theme implementation for displaying a username.

+++ b/core/themes/olivero/templates/views/views-view--frontpage.html.twig
@@ -0,0 +1,94 @@
+ * Default theme implementation for main view template.

Comments

mherchel created an issue. See original summary.

mherchel’s picture

Title: [Code Review] Correct twig documentation » Correct twig documentation in various Olivero templates
Project: Olivero » Drupal core
Version: 8.x-1.x-dev » 9.1.x-dev
Component: Code » Olivero theme
Priority: Normal » Minor
sarvjeetsingh’s picture

Status: Active » Needs review
StatusFileSize
new4.32 KB

please review.

markdorison’s picture

StatusFileSize
new4.31 KB
new578 bytes
abhijith s’s picture

StatusFileSize
new80.43 KB

Applied patch #4 and it works fine. The 'Default' word is generally used in documentation templates when the template is identical to their actual templates, which is different in this case.So this patch fixes these documentation errors.

Screenshot:
after

paulocs’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new15.33 KB

Patch #4 looks good.
All "Default theme" were replaced and were replaced correctly.

  • lauriii committed 9fb22e5 on 9.2.x
    Issue #3176906 by markdorison, sarvjeetsingh, paulocs: Correct twig...
lauriii’s picture

Committed 9fb22e5 and pushed to 9.2.x. Thanks!

Leaving open for 9.1.x backport.

  • lauriii committed f9ce3d5 on 9.1.x
    Issue #3176906 by markdorison, sarvjeetsingh, paulocs: Correct twig...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Cherry-picked to 9.1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.