Add yarn script commands for Drupal coding standard and Drupal Practice for Varbase Styleguide [#3175461]

Problem/Motivation

Saving time on checking standards and practice before committing any code.

#3113192: Drupal 9 compatibility for [Varbase Styleguide] with Drupal coding standard and practice

Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Varbase Styleguide Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

Check Varbase Styleguide Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

Proposed resolution

yarn eslint
yarn stylelint
yarn phpcs
yarn phpcbf

  "scripts": {
    "eslint": "node ./node_modules/eslint/bin/eslint.js --config=.eslintrc.json .",
    "stylelint": "npx stylelint --config=.stylelintrc.json .",
    "phpcs": "phpcs --standard=./.phpcs.xml .",
    "phpcbf": "phpcbf --standard=./.phpcs.xml ."
  },

Comment	File	Size	Author
#3	varbase-appearance-styleguide-2020-10-07_2_44_part4.png	10.68 MB	rajab natshah
#3	varbase-appearance-styleguide-2020-10-07_2_44_part3.png	9.78 MB	rajab natshah
#3	varbase-appearance-styleguide-2020-10-07_2_44_part2.png	12.51 MB	rajab natshah
#3	varbase-appearance-styleguide-2020-10-07_2_44_part1.png	5.17 MB	rajab natshah

Comments

Comment #1

7 October 2020 at 10:37

RajabNatshah created an issue. See original summary.

Comment #2

7 October 2020 at 11:15

RajabNatshah committed ec0b0d4 on 8.x-6.x

Issue #3175461: Add yarn script commands for Drupal coding standard and...

Comment #3

rajab natshah

he/him

commented 7 October 2020 at 11:54

Issue summary:

View changes

Status	File	Size
new	varbase-appearance-styleguide-2020-10-07_2_44_part1.png	5.17 MB
new	varbase-appearance-styleguide-2020-10-07_2_44_part2.png	12.51 MB
new	varbase-appearance-styleguide-2020-10-07_2_44_part3.png	9.78 MB
new	varbase-appearance-styleguide-2020-10-07_2_44_part4.png	10.68 MB

Comment #4

rajab natshah

he/him

commented 7 October 2020 at 12:04

Assigned:	rajab natshah	» mohammed j. razem
Category:	Bug report	» Task
Status:	Active	» Needs review
Issue tags:		+varbase-8.8.7, +varbase-9.0.0

The inline commands

rajab@vardot-dev:/var/www/html/products/varbase_styleguide$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

rajab@vardot-dev:/var/www/html/products/varbase_styleguide$ phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

No fixable errors were found

Time: 547ms; Memory: 10MB

rajab@vardot-dev:/var/www/html/products/varbase_styleguide$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

yarn phpcs

rajab@vardot-dev:/var/www/html/products/varbase_styleguide$ yarn phpcs
yarn run v1.22.5
$ phpcs --standard=./.phpcs.xml .
Done in 0.17s.

yarn phpcbf

rajab@vardot-dev:/var/www/html/products/varbase_styleguide$ yarn phpcbf
yarn run v1.22.5
$ phpcbf --standard=./.phpcs.xml .

No fixable errors were found

Time: 102ms; Memory: 8MB

Done in 0.18s.

yarn eslint

rajab@vardot-dev:/var/www/html/products/varbase_styleguide$ yarn eslint
yarn run v1.22.5
$ node ./node_modules/eslint/bin/eslint.js --config=.eslintrc.json .
Done in 0.87s.

yarn stylelint

rajab@vardot-dev:/var/www/html/products/varbase_styleguide$ yarn stylelint
yarn run v1.22.5
$ npx stylelint --config=.stylelintrc.json .
Done in 1.34s.