Problem/Motivation

Allow users to find documentation on trusted_host_patterns easily.

Proposed resolution

Add a comment in default.settings.php file near the trusted_host_patterns code pointing to the official documentation on this setting:

@see https://www.drupal.org/node/1992030

Remaining tasks

Commit the patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

Unnecessary.

CommentFileSizeAuthor
#22 interdiff-16-22.txt1.19 KBtunic
#22 3175428-link-trusted-hosts-doc-22.patch1.16 KBtunic
#16 3175428-16.patch872 bytesranjith_kumar_k_u
#10 interdiff_2-10.txt303 byteskishor_kolekar
#10 3175428-link-trusted-hosts-doc-10.patch466 byteskishor_kolekar
#4 interdiff.txt466 bytestunic
#4 3175428-link-trusted-hosts-doc-2.patch880 bytestunic
#2 3175428-link-trusted-hosts-doc-1.patch414 bytestunic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tunic created an issue. See original summary.

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
CreditAttribution: tunic at Metadrop commented
Status: Active » Needs review
FileSize
3175428-link-trusted-hosts-doc-1.patch414 bytes

Patch attatched.

Status: Needs review » Needs work

The last submitted patch, 2: 3175428-link-trusted-hosts-doc-1.patch, failed testing. View results

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
CreditAttribution: tunic at Metadrop commented
Status: Needs work » Needs review
FileSize
3175428-link-trusted-hosts-doc-2.patch880 bytes
interdiff.txt466 bytes

It turns out there's another file in assets that must be patched.

Let's try again.

Abhijith S’s picture

Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commented

Applied patch .Its working fine.Also the documentation URL given is correct

git apply -v 3175428-link-trusted-hosts-doc-2.patch
Checking patch core/assets/scaffold/files/default.settings.php...
Checking patch sites/default/default.settings.php...
Applied patch core/assets/scaffold/files/default.settings.php cleanly.
Applied patch sites/default/default.settings.php cleanly.
Abhijith S’s picture

Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commented

RTBC

Abhijith S’s picture

Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commented
Status: Needs review » Reviewed & tested by the community
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Reviewed & tested by the community » Needs work

I think these changes needs to be done in core/assets/scaffold/files/default.settings.php as well. Setting to NW to have that answered.

kishor_kolekar’s picture

kishor_kolekar CreditAttribution: kishor_kolekar as a volunteer and at QED42 for Drupal India Association commented
Assigned: Unassigned » kishor_kolekar
kishor_kolekar’s picture

kishor_kolekar CreditAttribution: kishor_kolekar as a volunteer and at QED42 for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3175428-link-trusted-hosts-doc-10.patch466 bytes
interdiff_2-10.txt303 bytes

changes as per commnet #8
please review the ptach.

kishor_kolekar’s picture

kishor_kolekar CreditAttribution: kishor_kolekar as a volunteer and at QED42 for Drupal India Association commented
Assigned: kishor_kolekar » Unassigned

Status: Needs review » Needs work

The last submitted patch, 10: 3175428-link-trusted-hosts-doc-10.patch, failed testing. View results

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
CreditAttribution: tunic at Metadrop commented
Status: Needs work » Needs review

#8, the first patch didn't and that's why it failed. However, the second patch (https://www.drupal.org/files/issues/2020-10-07/3175428-link-trusted-host...) changes both files:

  • core/assets/scaffold/files/default.settings.php
  • sites/default/default.settings.php

Patch from #10 only changes core/assets/scaffold/files/default.settings.php but it seems both files need to be changed.

Back to second patch and needs review status.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented

The #4 patch works fine on 9.2.x dev version.RTBC

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented
FileSize
3175428-16.patch872 bytes

Re-rolled from #4

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commented

Patch #4 applied successfully and looks good for me
Thanks for the patch

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Needs work

Let's link to the human readable URL - other places in settings.php use these... so https://www.drupal.org/docs/installing-drupal/trusted-host-settings

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
CreditAttribution: tunic at Metadrop commented
Status: Needs work » Needs review
FileSize
3175428-link-trusted-hosts-doc-22.patch1.16 KB
interdiff-16-22.txt1.19 KB

Links now use human-readable URLs.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC after the requested change came back green

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Category: Feature request » Task
Status: Reviewed & tested by the community » Fixed

Committed and pushed 648e58d053d to 10.0.x and 781ba3a616e to 9.4.x. Thanks!

  • alexpott committed 648e58d on 10.0.x 
    Issue #3175428 by tunic, kishor_kolekar, ranjith_kumar_k_u: Add link to...

  • alexpott committed 781ba3a on 9.4.x 
    Issue #3175428 by tunic, kishor_kolekar, ranjith_kumar_k_u: Add link to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.