Problem/Motivation

Saving time on checking standards and practice before committing any code.

#3113175: Drupal 9 compatibility for [Varbase FAQs] with Drupal coding standard and practice


Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Varbase FAQs Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_faqs/ --ignore=/var/www/html/products/varbase_faqs/node_modules/

phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_faqs/ --ignore=/var/www/html/products/varbase_faqs/node_modules/

Check Varbase FAQs Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_faqs/ --ignore=/var/www/html/products/varbase_faqs/node_modules/

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_faqs/ --ignore=/var/www/html/products/varbase_faqs/node_modules/


Proposed resolution

yarn eslint
yarn stylelint
yarn phpcs
yarn phpcbf

as

  "scripts": {
    "eslint": "node ./node_modules/eslint/bin/eslint.js --config=.eslintrc.json .",
    "stylelint": "npx stylelint --config=.stylelintrc.json .",
    "phpcs": "phpcs --standard=./.phpcs.xml .",
    "phpcbf": "phpcbf --standard=./.phpcs.xml ."
  },

Comments

RajabNatshah created an issue. See original summary.

  • RajabNatshah committed 54c7d89 on 8.x-6.x
    Issue #3173394: Add yarn script commands for Drupal coding standard and...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review
Issue tags: +varbase-8.8.7, +varbase-9.0.0

The Inline commands

rajab@vardot-dev:/var/www/html/products/varbase_faqs$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_faqs/ --ignore=/var/www/html/products/varbase_faqs/node_modules/
rajab@vardot-dev:/var/www/html/products/varbase_faqs$ phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_faqs/ --ignore=/var/www/html/products/varbase_faqs/node_modules/

No fixable errors were found

Time: 771ms; Memory: 10MB
rajab@vardot-dev:/var/www/html/products/varbase_faqs$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_faqs/ --ignore=/var/www/html/products/varbase_faqs/node_modules/

yarn phpcs

rajab@vardot-dev:/var/www/html/products/varbase_faqs$ yarn phpcs
yarn run v1.22.5
$ phpcs --standard=./.phpcs.xml .
Done in 0.18s.

yarn phpcbf

rajab@vardot-dev:/var/www/html/products/varbase_faqs$ yarn phpcbf
yarn run v1.22.5
$ phpcbf --standard=./.phpcs.xml .

No fixable errors were found

Time: 156ms; Memory: 8MB

Done in 0.24s.

yarn eslint

rajab@vardot-dev:/var/www/html/products/varbase_faqs$ yarn eslint
yarn run v1.22.5
$ node ./node_modules/eslint/bin/eslint.js --config=.eslintrc.json .
Done in 1.03s.

yarn stylelint

rajab@vardot-dev:/var/www/html/products/varbase_faqs$ yarn stylelint
yarn run v1.22.5
$ npx stylelint --config=.stylelintrc.json .
Done in 1.33s.
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.