Problem/Motivation

Due to cshs overriding core view's plugins instead of adding a new filter, this leads to a dilema. There's no way to fix the config schema. hook_config_schema_info_alter can't be used to add to the schema. There's no good path forward. Any suggestions how to resolve schema issues?

Steps to reproduce

Install module, add a term filter to a view. Then install config_inspector. I've got a site that strictly tests config schema during a CI build and this is tripping up the build.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 interdiff-3173040-7-8.txt9.51 KBbr0ken
#7 3173040-8.patch15.88 KBbr0ken
#6 3173040-7.patch11.28 KBheddn
#6 interdiff_5-7.txt2.12 KBheddn
#5 3173040-5.patch10.56 KBheddn
#4 3173040-4.patch2.79 KBheddn
#3 3173040.patch1.9 KBheddn
#2 2020-09-24_14-49.png44.19 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Issue summary: View changes
StatusFileSize
new 2020-09-24_14-49.png44.19 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Active » Needs review
StatusFileSize
new 3173040.patch1.9 KB

I'm not sure about the BC implications of this. I think it would cause issues for views that don't adjust the filter plugin_id. But it seems to fix things in such a way that we properly swap out the plugins. And for new site (mine as an example), it would just work.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
StatusFileSize
new 3173040-4.patch2.79 KB

Oops, missed the config schema in that last patch. Here we go.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
StatusFileSize
new 3173040-5.patch10.56 KB

No interdiff. This takes a different approach. And adds tests.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
StatusFileSize
new interdiff_5-7.txt2.12 KB
new 3173040-7.patch11.28 KB

I don't see tests are configured for this project. Perhaps that can be fixed.

br0ken’s picture

br0ken
Primary language Ukrainian
commented
StatusFileSize
new 3173040-8.patch15.88 KB
new interdiff-3173040-7-8.txt9.51 KB

  • BR0kEN committed c667d39 on 8.x-1.x 
    Issue #3173040 by heddn, BR0kEN: Views schema is broken
br0ken’s picture

br0ken
Primary language Ukrainian
commented
Status: Needs review » Fixed

Thanks @heddn.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.