Problem/Motivation

We don't need to display the "Delete this item from the system" option when removing items from an entityqueue and it's better to keep them separate.

Steps to reproduce

Given that an entityqueue dose have number of items
And the form display for the entityqueue was configured to "Inline Entity form - Complex"
When I try to remove an entity
Then I should not see "Delete this item from the system"

Proposed resolution

Remove the access to delete the entity when we remove it from the queue

Remaining tasks

  • Test
  • Commit the patch
  • Release

User interface changes

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#6 Edit-subqueue-Media-Hero-Slider-dev-varbase8c1-after.png102.67 KBrajab natshah
#6 Edit-subqueue-Media-Hero-Slider-dev-varbase8c1-before.png107.41 KBrajab natshah
#2 disable_delete_entity_entityqueue-3170170-2.patch1.56 KBmhawwari

Comments

mhawwari created an issue. See original summary.

mhawwari’s picture

mhawwari commented
Assigned: mhawwari » Unassigned
Status: Active » Needs work
StatusFileSize
new disable_delete_entity_entityqueue-3170170-2.patch1.56 KB
mhawwari’s picture

mhawwari commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: disable_delete_entity_entityqueue-3170170-2.patch, failed testing. View results

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs work » Needs review
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
StatusFileSize
new Edit-subqueue-Media-Hero-Slider-dev-varbase8c1-before.png107.41 KB
new Edit-subqueue-Media-Hero-Slider-dev-varbase8c1-after.png102.67 KB
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

  • RajabNatshah committed ff0c789 on 9.0.x authored by mhawwari 
    Issue #3170170 by mhawwari: Disable the checkbox to delete referenced...
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Issue tags: +varbase-8.8.7, +varbase-9.0.0 
rajab@vardot-dev:/var/www/html/products/varbase_core$ yarn phpcs
yarn run v1.22.5
$ phpcs --standard=./.phpcs.xml .
Done in 1.04s.
rajab@vardot-dev:/var/www/html/products/varbase_core$ yarn phpcbf
yarn run v1.22.5
$ phpcbf --standard=./.phpcs.xml .

No fixable errors were found

Time: 959ms; Memory: 16MB

Done in 1.04s.
rajab@vardot-dev:/var/www/html/products/varbase_core$ yarn eslint
yarn run v1.22.5
$ node ./node_modules/eslint/bin/eslint.js --config=.eslintrc.json .
Done in 1.47s.
rajab@vardot-dev:/var/www/html/products/varbase_core$ yarn stylelint
yarn run v1.22.5
$ npx stylelint --config=.stylelintrc.json .
Done in 2.46s.
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed

  • RajabNatshah committed 4428988 on 8.x-8.x authored by mhawwari 
    Issue #3170170 by mhawwari: Disable the checkbox to delete referenced...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.