Problem/Motivation

The extra module jsonapi_defaults contains options to add in default filters but not default sorting.
Would be good if changes could be made to also add this feature.

CommentFileSizeAuthor
#6 jsonapi_extras-default-sorting-3169654-6.patch8.26 KB3li
#2 jsonapi_extras-default-sorting-3169654-2.patch5.58 KB3li

Issue fork jsonapi_extras-3169654

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Eli.Stone created an issue. See original summary.

3li’s picture

3li
he/him
Primary language English
Location U.K. 🇬🇧
commented
StatusFileSize
new jsonapi_extras-default-sorting-3169654-2.patch5.58 KB

Have added options for default sorting, inside the jsonapi_defaults module.

3li’s picture

3li
he/him
Primary language English
Location U.K. 🇬🇧
commented
Status: Active » Needs review
bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Needs work

Thanks for helping out! This is quite usefull.

Looking good but is missing tests. Could you add a test that applies the sort and one that then overrides it? Have a look at JsonApiExtrasFunctionalTest::testSortOverwrittenField for inspiration :)

3li’s picture

3li
he/him
Primary language English
Location U.K. 🇬🇧
commented

Sure will look at adding test ASAP.

3li’s picture

3li
he/him
Primary language English
Location U.K. 🇬🇧
commented
Status: Needs work » Needs review
StatusFileSize
new jsonapi_extras-default-sorting-3169654-6.patch8.26 KB

Have added some tests for checking default sorting and confirming overriding default sorting takes priority.

Eli.Stone opened merge request !1

3li’s picture

3li
he/him
Primary language English
Location U.K. 🇬🇧
commented

Opened up merge request as easier to review & test :)

abu-zakham’s picture

abu-zakham commented
Status: Needs review » Reviewed & tested by the community

Worked for me.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the work! Reviewed and pushes :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.