Doesn't allow for Internal links

Sti

Still not working in the 1.1 version

Hi guys, why is this merge request for?

Ok I will be opening it again

I am attempting to switch over from the older Block Title Link module because of lack of activity there with producing a stable D8/D9 version.

However I am also experiencing this issue in both 1.1.2 and 1.1.x-dev (5 Mar 2021) in Drupal 8.9.13. It will not accept internal links such as `/authorities`. When I try to save the block it just prompts "Please enter a URL".

I was able to enter this type of link in the other Block Title Link module (also with D8.9.13 and with this patch).

I confirm the internal paths still don't work! Drupal 9.1.7
I think you need to reopen the ticket.

Yep, I can also confirm #16

@smustgrave The diff you linked to will apply to 1.1.2 (which I guess is the same as 1.1.x-dev - both dated 5th March), but the following error is thrown when visiting a Configure block page (in both Drupal 8.9.14 and 9.1.7):

Warning: get_called_class() called from outside a class in block_title_link_form_block_form_alter() (line 36 of modules\contrib\block_title_link\block_title_link.module).

block_title_link_form_block_form_alter(Array, Object, 'block_form') (Line: 539)
Drupal\Core\Extension\ModuleHandler->alter('form', Array, Object, 'block_form') (Line: 836)
Drupal\Core\Form\FormBuilder->prepareForm('block_form', Array, Object) (Line: 279)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 158)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 706)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Edit: I went ahead and checked it with 1.1.x-dev and the same error is thrown.

There may be inspiration in the older Block Title Link module, but it's a bit of a mess because not even a D8 dev version was ever released. But a working D8 version can be constructed using my patch against the D7 version. Internal links worked OK in it.

#24 is working for internal links (by patching with https://git.drupalcode.org/project/block_title_link/-/merge_requests/2/diffs.diff), so thank you for that.

Regarding #20, get_called_class() has been completely removed from core and replaced with static::class (see here and here). So after patching with #20 I tried replacing '#element_validate' => [[get_called_class(), 'validateUriElement']], with the apparently-like-for-like '#element_validate' => [[static::class, 'validateUriElement']],. VSCode tells me 'Cannot use "static" when no class scope is active'. Which led me to this. Does it help? I'm not a coder.

@smustgrave got this error when it tried to access any block config page

Error: Class 'EntityAutocomplete' not found in getUriAsDisplayableString() (line 119 of /Users/Documents/sites/optimus/web/modules/custom/block_title_link/block_title_link.module)

Add block title data to any of the block configs, save it, and then when you revisit it, this error is occurring, and I am also using core 9.2

I haven't seen error #28 using Drupal 9.1.7/8. I'm only using this module for links on the titles of Hierarchical Taxonomy Menu blocks.

Ok, we had to add use Drupal\Core\Entity\Element\EntityAutocomplete; , because of this error was occurring for me, will commit it and make a release soon.

Committed to the dev branch, will create new release soon 👍🏻. Thanks.

Thanks guys. 1.1.3 working fine in D9.1.8.