Using D9.0.3

php error when installing footnotes:

User deprecated function: Theme functions are deprecated in drupal:8.0.0 and are removed from drupal:10.0.0. Use Twig templates instead of theme_footnote_link(). See https://www.drupal.org/node/1831138 in Drupal\Core\Theme\Registry->processExtension() (line 498 of core/lib/Drupal/Core/Theme/Registry.php).
Drupal\Core\Theme\Registry->processExtension(Array, 'footnotes', 'module', 'footnotes', 'modules/contrib/footnotes') (Line: 341)
Drupal\Core\Theme\Registry->build() (Line: 240)
Drupal\Core\Theme\Registry->get() (Line: 88)

CommentFileSizeAuthor
#26 code_3169299-26.png131.35 KBkleiton_rodrigues
#26 site_3169299-26.png25.09 KBkleiton_rodrigues
#25 interdiff-3169299-23-25.txt731 bytesscott_euser
#25 footnotes-drupal9-theme-functions-3169299-25.patch6.07 KBscott_euser
#23 drupal9_compatible-3169299-23.patch6.32 KBszds
#21 drupal9_compatible-3169299-19.patch5.96 KBcestmoi
#18 drupal9_compatible-3169299-18.patch6.29 KBszds
#15 drupal9_compatible-3169299-14.patch6.28 KBszds
#13 drupal9_compatible-3169299-13.patch6.76 KBszds
#7 Screenshot_20201121_134431.png66.2 KBAnticoVeneziano
#5 footnotes-deprecated_function-3169299-5.patch3.43 KBphjou
#6 Screenshot_20201121_131253.png78.69 KBAnticoVeneziano

Issue fork footnotes-3169299

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Yuri created an issue. See original summary.

Yuri’s picture

Yuri commented
Issue summary: View changes
Yuri’s picture

Yuri commented
Priority: Normal » Major

setting to Major because this error prevents database updates

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented

I confirm this bug, lots of warnings in the logs everytime you load a ckeditor.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
StatusFileSize
new footnotes-deprecated_function-3169299-5.patch3.43 KB

Ok I think I did the minimal patch needed to fix this. The generation of the HTML that is spit for the list seems pretty old school php but I didn't want to touch that part to avoid regressions. It probably should be done in a different issue after this one.

Let me know if this patch works for you. It seems ok for me on Drupal 9.

AnticoVeneziano’s picture

AnticoVeneziano commented
StatusFileSize
new Screenshot_20201121_131253.png78.69 KB

hi,
thanks! but
the patch cleaned the warnings, but sadly now all the html tags appears in the footnotes...

AnticoVeneziano’s picture

AnticoVeneziano commented
StatusFileSize
new Screenshot_20201121_134431.png66.2 KB

hi,
on localhost everything works fine with the same website, and also with a simple installation of drupal 9...
online warnings (without patch) or tags exposed (with patch)...

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Status: Active » Needs review
cestmoi’s picture

cestmoi commented

same as in comment #6 but it's happening on localhost and haven't tested online. The patch makes the module useless this way unfortunately. on Latest drupal 9.1.2

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Status: Needs review » Needs work
baluertl’s picture

baluertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
commented
Title: User deprecated function: Theme functions » Use of deprecated theme functions
baluertl’s picture

baluertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
commented

Also important to check whether CKEditor loads properly on /node/add/page and /node/{NID}/edit pages? For me enabling the patched Footnotes module breaks WYSIWYG functionality by some strange reasons.

szds’s picture

szds commented
StatusFileSize
new drupal9_compatible-3169299-13.patch6.76 KB

Here is a patch for the version 8.x-2.1 which is tested to work for D9.1.3 .

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented 
+++ b/footnotes.module
@@ -30,85 +30,21 @@ function footnotes_help($route_name, RouteMatchInterface $route_match) {
 }

Looks like tabs instead of spaces.

szds’s picture

szds commented
StatusFileSize
new drupal9_compatible-3169299-14.patch6.28 KB

Similar to patch in #13 with array() changed to [] and tabs replaced with spaces. Tested for D9.1.3 for add/edit nodes and CKEditor.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Status: Needs work » Needs review
cestmoi’s picture

cestmoi commented

The patch in #15 got rid of the warning and everything looks fine except for when the footnote has any html it's then exposed in the footnote text display. Otherwise, the list and numbering seems fine.

Tested locally for D9.1.4 for add/edit node and CKEditor

szds’s picture

szds commented
StatusFileSize
new drupal9_compatible-3169299-18.patch6.29 KB

HTML in the footnotes is an interesting use case. In the source you have to add html within the <fn></fn> tags. For the CKEditor the Source button has to be available.

You can render HTML by using the raw filter in the twig file. In general, this is not the best approach. At least for the CKEditor, XSS can be avoided by ensuring that the Text format filters out some tags (e.g. script tag).

Here is a patch that allows the rendering of HTML in the footnotes. It differs from the patch in #15 only by adding the raw filter to the footnote-list.html.twig file.

cestmoi’s picture

cestmoi commented

The last patch in #18 is working great now. Tested with html in footnote text and all looks great now. Thanks @szds

On latest Drupal 9.1.4 and Footnotes 2.x-dev

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented

Let's see if tests are passing on D9.1.

cestmoi’s picture

cestmoi commented
StatusFileSize
new drupal9_compatible-3169299-19.patch5.96 KB

The patch test is failing I think due to the version patch in .info which is not needed as this module dev version is already converted to D9.
I just removed the patch part for the .info file and let's re-test it

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Status: Needs review » Needs work
szds’s picture

szds commented
StatusFileSize
new drupal9_compatible-3169299-23.patch6.32 KB

Here is the patch for the dev version 8.x-2.x-dev

This also fixes the issue (3195978) wherein the footnotes list currently can only be placed at the default location at the end of the node; adding a placeholder [footnotes] or [footnotes /] or <footnotes> , within the content adds the footnotes list but removes the text subsequent to the location of the placeholder.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Status: Needs work » Needs review
scott_euser’s picture

scott_euser commented
StatusFileSize
new footnotes-drupal9-theme-functions-3169299-25.patch6.07 KB
new interdiff-3169299-23-25.txt731 bytes

Just a quick fix to coding standards indentation, but otherwise this works well for me in Drupal 9, gets rid of deprecation notices + nicely allows better theme control over the output, so win win, thanks! RTBC from me (but since the coding standards change, will leave at NR).

kleiton_rodrigues’s picture

kleiton_rodrigues commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new site_3169299-26.png25.09 KB
new code_3169299-26.png131.35 KB

Tested your patch looks good to me...
thanks!
RTBC +1

  • pifagor committed d021811 on 8.x-2.x authored by scott_euser 
    Issue #3169299 by szds, Balu Ertl, scott_euser, cestmoi, phjou,...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed

Thanks,fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.