Problem/Motivation

From #3166543: Deprecate UiHelperTrait::drupalPostForm, keep deprecation silenced -

calls to drupalPostForm(NULL, ...) are easy to convert to submitForm since there is no need to visit an URL prior to POSTing the form.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#16 Convert_calls-3168375-16.patch533.37 KBmanishsaharan
#15 3168375-15.patch533.37 KBmondrake
#15 interdiff_13-15.txt3.43 KBmondrake
#13 interdiff_11-13.txt3.85 KBmondrake
#13 3168375-13.patch533.11 KBmondrake
#11 3168375-11.patch532.61 KBmondrake
#7 3168375-7-for-review-do-not-test.patch533.86 KBmondrake
#7 3168375-7.patch1.22 MBmondrake
#2 3168375-2.patch534.21 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new 3168375-2.patch534.21 KB

Patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Related issues: +#3145005: [November 9, 2020] Remove uses of t() in drupalPostForm() calls

As #3145005: [November 9, 2020] Remove uses of t() in drupalPostForm() calls was requested to be scheduled due to disruption I imagine this will be as well, and they will definitely have a lot of conflicts!

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Postponed

Let’s postpone on that one, then. That means this will be 9.2 material.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Active
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new 3168375-7.patch1.22 MB
new 3168375-7-for-review-do-not-test.patch533.86 KB

Reroll, built on top of #3145005: [November 9, 2020] Remove uses of t() in drupalPostForm() calls.

The last submitted patch, 7: 3168375-7.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Needs work
manishsaharan’s picture

manishsaharan commented
Assigned: Unassigned » manishsaharan

I am working on this issue

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new 3168375-11.patch532.61 KB

Status: Needs review » Needs work

The last submitted patch, 11: 3168375-11.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new 3168375-13.patch533.11 KB
new interdiff_11-13.txt3.85 KB

Status: Needs review » Needs work

The last submitted patch, 13: 3168375-13.patch, failed testing. View results

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_13-15.txt3.43 KB
new 3168375-15.patch533.37 KB
manishsaharan’s picture

manishsaharan commented
StatusFileSize
new Convert_calls-3168375-16.patch533.37 KB

Removed uses of drupalPostForm().

manishsaharan’s picture

manishsaharan commented
Assigned: manishsaharan » Unassigned
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

This is a straightforward find and replace, plus a simple deprecation and test. Reviewed with git diff --color-words, no issues spotted.

  • catch committed 96d4338 on 9.2.x 
    Issue #3168375 by mondrake, manishsaharan29497, longwave: Convert calls...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

  • catch committed 3bf7371 on 9.1.x 
    Issue #3168375 by mondrake, manishsaharan29497, longwave: Convert calls...
mondrake’s picture

mondrake
Location 🇮🇹
commented

Filed #3184324: Convert calls to drupalPostForm() that assign return value to a variable.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.