CommentFileSizeAuthor
#11 interdiff-3168002-11.txt392 bytesjigish.addweb
#11 3168002-11.patch126.19 KBjigish.addweb
#8 interdiff-3168002-8.txt16.07 KBjigish.addweb
#8 3168002-8.patch126.16 KBjigish.addweb
#5 3168002-5.patch119.89 KBjigish.addweb
#4 3168002-4.patch119.89 KBjigish.addweb
#3 interdiff-3168002-3.txt576 bytesjigish.addweb
#3 3168002-3.patch120.12 KBjigish.addweb
#2 3168002-2.patch119.88 KBjigish.addweb

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Issue summary: View changes
StatusFileSize
new 3168002-2.patch119.88 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3168002-3.patch120.12 KB
new interdiff-3168002-3.txt576 bytes
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3168002-4.patch119.89 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3168002-5.patch119.89 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddwewb

Thank you for adding the Cloud Service Provider ID columns. I tested the patch --- could you please add ascending sorting order to all those columns?

Thanks

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3168002-8.patch126.16 KB
new interdiff-3168002-8.txt16.07 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

I added ascending sorting order to all cloud service provider column in all k8s views.

Please review the updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for the update. I tested the patch and it looks good to me now.

+++ b/modules/cloud_service_providers/k8s/k8s.install
@@ -2133,6 +2133,44 @@ function k8s_update_8292() {
+function k8s_update_8293() {

Could you please add drupal_flush_all_caches(); at the end of this hook_update_N() function?

jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3168002-11.patch126.19 KB
new interdiff-3168002-11.txt392 bytes

@yas

I added drupal_flush_all_caches(); in hook_update_N() function.

Please review the new patch file.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. it looks good to me. I'll merge the patch to 8.x-1.x, 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 7d12cae on 8.x-1.x authored by jigish.addweb 
    Issue #3168002 by jigish.addweb, yas: Add Cloud service provider column...

  • yas committed b55a0a5 on 8.x-2.x authored by jigish.addweb 
    Issue #3168002 by jigish.addweb, yas: Add Cloud service provider column...

  • yas committed 1aaaf99 on 3.x authored by jigish.addweb 
    Issue #3168002 by jigish.addweb, yas: Add Cloud service provider column...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.