Problem/Motivation
The commit in #3138991 does not do anything except add unneeded white space in .yml files.
Proposed resolution
Revert commit b2c44e3932549741a9d2b5f447b7c1dab13aa87c.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | bootstrap_bario-reverts-3138991-3165663-3.patch | 36.13 KB | loopduplicate |
Comments
Comment #2
loopduplicate commentedComment #3
loopduplicate commentedComment #5
hatuhay commentedComment #7
rajab natshahMapping is empty
When you try to do Configuration inspection you will get Schema Errors
Please a Physical real testing in both Drupal 8 and Drupal 9 is important
try to save the theme settings, and the Sub theme settings, when the full error report is on and the configuration inspection for Drupal standard coding and standard practices
Schema mapping for configs and sub themes too.
test with PHP 7.3 & MySQL 5.7, Drupal 9.0.0
https://www.drupal.org/pift-ci-job/1729074
Comment #8
hatuhay commented@RajabNatshah
Did you found this on 5.1.0 or 5.1.1?
Comment #9
loopduplicate commentedRajabNatshah's test results show that 8.x-4.29 was used.
https://dispatcher.drupalci.org/job/drupal_contrib/219481/artifact/jenki...
Comment #10
loopduplicate commentedAfter looking into this closer, I agree with RajabNatshah; the indentations are required. Sorry about that. I don't know how I missed that the entries were under mapping.
Comment #11
rajab natshahThank you for following up
#3138991: Fix schema mapping for Bootstrap Barrio
https://www.drupal.org/project/bootstrap_barrio/issues/3138991#comment-1...
If you are using the
mapping:in the .schema.yml fileas in the following example
https://git.drupalcode.org/project/mayo/-/blob/8.x-1.x/config/schema/may...
But you do have it as
https://git.drupalcode.org/project/bootstrap_barrio/-/blob/8.x-4.x/confi...
Is the mapping in the
bootstrap_barrio.settings:needed or each config schema will be in file or a config value?Properly use config schema for theme settings
#3068483: Automatically map !translate YAML tag to TranslatableMarkup
#2065571: Add YAML Plugin discovery
Comment #13
rajab natshahThank you Alberto for maintaining the Barrio base theme
And for all time you put into it.
#3170658: Upgrade [Bootstrap Barrio] base theme from ~4.0 to ~5.0
Not sure if you had a look at comment #10
Comment #14
rajab natshahThank you Alberto
Happy for having
#3178809: Properly fix and test config schema
Comment #15
rajab natshah