Problem/Motivation

The commit in #3138991 does not do anything except add unneeded white space in .yml files.

Proposed resolution

Revert commit b2c44e3932549741a9d2b5f447b7c1dab13aa87c.

Comments

loopduplicate created an issue. See original summary.

loopduplicate’s picture

Issue summary: View changes
loopduplicate’s picture

Assigned: loopduplicate » Unassigned
Status: Active » Needs review
StatusFileSize
new36.13 KB

hatuhay’s picture

Status: Needs review » Fixed

rajab natshah’s picture

Mapping is empty

  label: 'Bootstrap Barrio settings'
  mapping:

When you try to do Configuration inspection you will get Schema Errors

Please a Physical real testing in both Drupal 8 and Drupal 9 is important
try to save the theme settings, and the Sub theme settings, when the full error report is on and the configuration inspection for Drupal standard coding and standard practices

Schema mapping for configs and sub themes too.
test with PHP 7.3 & MySQL 5.7, Drupal 9.0.0
https://www.drupal.org/pift-ci-job/1729074

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for bootstrap_barrio.settings with the following errors: bootstrap_barrio.settings:bootstrap_barrio_library missing schema, bootstrap_barrio.settings:bootstrap_barrio_sidebar_position missing schema, bootstrap_barrio.settings:bootstrap_barrio_content_offset missing schema, bootstrap_barrio.settings:bootstrap_barrio_sidebar_first_width missing schema, bootstrap_barrio.settings:bootstrap_barrio_sidebar_first_offset missing schema, bootstrap_barrio.settings:bootstrap_barrio_sidebar_second_width missing schema, bootstrap_barrio.settings:bootstrap_barrio_sidebar_second_offset missing schema, bootstrap_barrio.settings:bootstrap_barrio_fluid_container missing schema, bootstrap_barrio.settings:bootstrap_barrio_button missing schema, bootstrap_barrio.settings:bootstrap_barrio_button_size missing schema, bootstrap_barrio.settings:bootstrap_barrio_button_outline missing schema, bootstrap_barrio.settings:bootstrap_barrio_navbar_toggle missing schema, bootstrap_barrio.settings:bootstrap_barrio_navbar_container missing schema, bootstrap_barrio.settings:bootstrap_barrio_navbar_top_position missing schema, bootstrap_barrio.settings:bootstrap_barrio_navbar_top_color missing schema, bootstrap_barrio.settings:bootstrap_barrio_navbar_top_background missing schema, bootstrap_barrio.settings:bootstrap_barrio_navbar_position missing schema, bootstrap_barrio.settings:bootstrap_barrio_navbar_color missing schema, bootstrap_barrio.settings:bootstrap_barrio_navbar_background missing schema, bootstrap_barrio.settings:bootstrap_barrio_messages_widget missing schema, bootstrap_barrio.settings:bootstrap_barrio_radio missing schema, bootstrap_barrio.settings:bootstrap_barrio_checkbox missing schema, bootstrap_barrio.settings:bootstrap_barrio_select missing schema, bootstrap_barrio.settings:bootstrap_barrio_file missing schema, bootstrap_barrio.settings:bootstrap_barrio_system_messages missing schema, bootstrap_barrio.settings:bootstrap_barrio_table_hover missing schema, bootstrap_barrio.settings:bootstrap_barrio_table_style missing schema, bootstrap_barrio.settings:bootstrap_barrio_bootstrap_icons missing schema, bootstrap_barrio.settings:_core missing schema, bootstrap_barrio.settings:langcode missing schema

/var/www/html/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:95
/var/www/html/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:111
/var/www/html/core/lib/Drupal/Core/Config/Config.php:231
/var/www/html/core/lib/Drupal/Core/Config/ConfigInstaller.php:380
/var/www/html/core/lib/Drupal/Core/Config/ConfigInstaller.php:137
/var/www/html/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/var/www/html/core/lib/Drupal/Core/Extension/ThemeInstaller.php:232
/var/www/html/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:430
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:580
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:400
/var/www/html/themes/contrib/vartheme_bs4/tests/src/Functional/VarthemeBs4Tests.php:51
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:691

hatuhay’s picture

@RajabNatshah
Did you found this on 5.1.0 or 5.1.1?

loopduplicate’s picture

RajabNatshah's test results show that 8.x-4.29 was used.
https://dispatcher.drupalci.org/job/drupal_contrib/219481/artifact/jenki...

loopduplicate’s picture

After looking into this closer, I agree with RajabNatshah; the indentations are required. Sorry about that. I don't know how I missed that the entries were under mapping.

rajab natshah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Thank you Alberto for maintaining the Barrio base theme
And for all time you put into it.

#3170658: Upgrade [Bootstrap Barrio] base theme from ~4.0 to ~5.0

Not sure if you had a look at comment #10

rajab natshah’s picture

Thank you Alberto
Happy for having
#3178809: Properly fix and test config schema

rajab natshah’s picture