Use the page entity title when available

The patch does work and gets the entity title, but because this is a feature request, I'm in no position of saying if this is something that needs to be implemented or not. So I'm leaving it on needs review so others can leave their opinions.

Thanks for the patch. Can you give me a bit more context? What's the difference between an entity label and page title? How does oneset an entity label on a page? Can you give me an example page to test on?

~G

@Greg Boggs the title is the entity label. if you review the patch. There are this code

$title = $entity->label();

For the test, you only need to apply the patch and configure this option at the breadcrumbs configuration form.

Note that the patch difference is this: "Use the real page title when it is available instead of always deducing it from the URL. The page entity title setting above will take precedence over this setting. So, one or the other, but not both." (Extracted from the patch)

Is there a drupal page we can test on to see this one in action? node/edit maybe?

wrong issue.

Oh after reviewing the issue more in deep I understand better your questions.

The configuration form already has this option with this description:

- Use the real page title when available
(Use the real page title when it is available instead of always deducing it from the URL.)

However, this not works when the page is an entity like a page_manager(module) instance where the breadcrumb block is showing into a region of this.

In this scenario, I propose a new patch that fixes this.

To test:
Implement a page_manager module, create a page for nodes, add a block to this page to show the breadcrumbs, and note that without the patch the breadcrumb show "Node" not the correct title.

Looks like the import statement from the patch did not make it to the commit in gitlab.

use Drupal\Core\Entity\ContentEntityInterface;

https://git.drupalcode.org/project/easy_breadcrumb/-/commit/d8f854c67bfb...

This is causing this if statement to be false and skipping loading the entity label.

if ($entity instanceof ContentEntityInterface && $entity->hasLinkTemplate('canonical')) {

Here is a patch adding the import.

@philtran the last patch #9 has the code use Drupal\Core\Entity\ContentEntityInterface; BTW the current stable version for easy_breadcrumb module has this feature functionally

@vacho Thanks for the comment. Looks like it got committed but not noted in this thread. https://git.drupalcode.org/project/easy_breadcrumb/-/commit/5976b2d36dd8...